Skip to content

Adding output fields to data_source #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2025
Merged

Adding output fields to data_source #368

merged 1 commit into from
Feb 7, 2025

Conversation

ljstella
Copy link
Contributor

@ljstella ljstella commented Feb 7, 2025 •
edited
Loading

Replacing #361 which has taken on a new purpose.

This is targeting splunk/security_content#3301

@ljstella ljstella requested a review from pyth0n1c February 7, 2025 17:30
pyth0n1c
pyth0n1c approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@pyth0n1c pyth0n1c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. A more straightforward PR like this makes sense to merge immediately rather than a more robust one as we figure out the future usage of the DataSource Object.

@pyth0n1c pyth0n1c merged commit 8cc3dbe into main Feb 7, 2025
16 checks passed
@ljstella ljstella mentioned this pull request Feb 13, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyth0n1c pyth0n1c pyth0n1c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljstella @pyth0n1c