Make data_sources lookup case insensitive #429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patel-bhavin
approved these changes
Jul 15, 2025
pyth0n1c
approved these changes
Jul 30, 2025
Contributor
pyth0n1c
left a comment
pyth0n1c
left a comment
There was a problem hiding this comment.
Based on included discussion and ticket, I agree that this is correct. Thanks for the additional context and feedback team!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, casing is weird. Search is generally case insensitive for fields (like sourcetype)- but field extraction based on the sourcetype is not necessarily case insensitive. The real example case here for this is
xmlwineventlogvsXmlWinEventlog(or eventxMlWiNeVeNtLoGif you want to cause pain) - the extractions applied to each one could be different, depending on the version of Splunk, the version of the TA, etc. But generally these are "equivalent-ish". Rather than tell customers that their data ofxmlwineventlogdoesn't satisfyXmlWinEventLog, we should probably hope they know their data isn't broken to a considerable degree.See TR-4187.