GenAI Utils Inference #2
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradystar
reviewed
Aug 19, 2025
pradystar
reviewed
Aug 19, 2025
util/opentelemetry-util-genai/src/opentelemetry/util/genai/client.py
Outdated
Show resolved
Hide resolved
pradystar
reviewed
Aug 19, 2025
| ) -> LLMInvocation: | ||
| with self._lock: | ||
| invocation = self._llm_registry.pop(run_id) | ||
| invocation.end_time = time.time() |
There was a problem hiding this comment.
this isn't thread safe all operations should be within the lock. The same for emitter.emit and same for emitter.init
pradystar
reviewed
Aug 19, 2025
util/opentelemetry-util-genai/src/opentelemetry/util/genai/client.py
Outdated
Show resolved
Hide resolved
pradystar
reviewed
Aug 19, 2025
util/opentelemetry-util-genai/src/opentelemetry/util/genai/emitters.py
Outdated
Show resolved
Hide resolved
pradystar
reviewed
Aug 20, 2025
| start_time: float | ||
| request_model: Optional[str] = None | ||
| system: Optional[str] = None | ||
| db_system: Optional[str] = None |
pradystar
reviewed
Aug 20, 2025
|
|
||
| def _message_to_event(message, system, framework) -> Optional[Event]: | ||
| content = _get_property_value(message, "content") | ||
| if content: |
There was a problem hiding this comment.
in the poc there was a todo item to check if content should be collected, is that no longer needed?
pradystar
reviewed
Aug 20, 2025
| attributes = { | ||
| # TODO: add below to opentelemetry.semconv._incubating.attributes.gen_ai_attributes | ||
| "gen_ai.framework": framework, | ||
| GenAI.GEN_AI_SYSTEM: system, |
There was a problem hiding this comment.
why is gen_ai.provider.name not included?
There was a problem hiding this comment.
I only see SYSTEM_NAME in our constants. I've added the provider_name manually, with a todo to update once the semconvs from python catches up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creation of tools for GenAI utils for generating spans for inference calls.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.