-
Notifications
You must be signed in to change notification settings - Fork 420
Correct "remote_access_software" Lookup to Match macOS Processes from NVM Input #3569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gneff
wants to merge
7
commits into
splunk:develop
Choose a base branch
from
gneff:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6d909f9
Fix Detections For Remote Access Software Processes on macOS
729cc20
Revert "Fix Detections For Remote Access Software Processes on macOS"
gneff 34c8626
Fix Detections For Remote Access Software Processes on macOS
gneff fcd2fc8
Revert "Fix Detections For Remote Access Software Processes on macOS"
gneff d0398ba
Fix Detections For Remote Access Software Processes on macOS
gneff 72052cb
Merge branch 'develop' into develop
ljstella 739ddd2
Merge branch 'develop' into develop
patel-bhavin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lookup is used by other analytics. Why not rename the field in your search instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original query had a rename (left it in here commented out), but it never matched any processes on macOS hosts:
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is a working example from the repo renaming the field to process for use
security_content/detections/endpoint/detect_remote_access_software_usage_process.yml
Lines 23 to 32 in 5fa7311
I'm no expert on SPL but I think this might be an issue in your search.
But imo the solution is not renaming the lookup to fit (only) your need.