-
Notifications
You must be signed in to change notification settings - Fork 127
fix isAppAlreadyInstalledo error handling #1608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
patrykw-splunk
merged 8 commits into
develop
from
feature/fix-error-handling-in-afwscheduler
Nov 24, 2025
Merged
fix isAppAlreadyInstalledo error handling #1608
patrykw-splunk
merged 8 commits into
develop
from
feature/fix-error-handling-in-afwscheduler
Nov 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasiakoziol
approved these changes
Nov 5, 2025
rlieberman-splunk
approved these changes
Nov 7, 2025
Collaborator
Pull Request Test Coverage Report for Build 19546229803Details
💛 - Coveralls |
kubabuczak
reviewed
Nov 14, 2025
977edc7 to
6546a3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix FIPS Error Handling:
Modified
isAppAlreadyInstalled()andinstallApp()functions to properly handle FIPS provider informational messages in stderr by treating them as non-error conditions rather than installation failures.Also added fanout CR status synchronization (
installPhaseManager()) to ensure that when app installation fails after max retries on any replica, the main PhaseInfo is properly updated to reflect the overall deployment failure state.Key Changes
FIPS error handling
isAppAlreadyInstalled()function to detect and ignore FIPS provider informational messages in stderr instead of treating them as errorsinstallApp()function to handle FIPS messages during app installation, preventing false installation failuresFanout CR Status Management
Testing and Verification
TestRunLocalScopedPlaybook
✅ Fixed Test3: Now uses proper exit codes (fmt.Errorf("exit status 2")) instead of stderr-only failures
✅ Fixed Test4: Properly simulates grep exit code 1 for app-not-enabled scenarios
✅ Fixed Test6: Updated to test stderr content transparency
TestPremiumAppScopedPlaybook:
✅ Fixed Test3: Uses real error conditions with proper exit codes
✅ Fixed Test4: Corrected install failure simulation with err != nil
✅ Fixed Test5: Updated to test generic stderr content handling
✅ Fixed Test7: App-already-installed scenario with stderr content
TestIsAppAlreadyInstalled:
✅ Updated test cases to be FIPS-agnostic
✅ "stderr content" in test names and descriptions
✅ Tests now focus on behavior: stderr content should be ignored for error detection
✅ Comprehensive coverage: success, not-found, real errors, edge cases
Related Issues
N/A
PR Checklist