Skip to content

CSPL-4282 fix pipeline race condition and misconfiguration #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kubabuczak merged 3 commits into from
Dec 1, 2025
Merged

CSPL-4282 fix pipeline race condition and misconfiguration #1628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7845d87
SCPL-4282 Fix: pipelines race condition and pipelines misconfiguration
kubabuczak Nov 27, 2025
b848760
CSPL-4282 Update Makefile for Jekyll documentation preview and enhanc…
kubabuczak Nov 27, 2025
f39eefb
Add EKS Test Cluster Name Action and update workflows
kubabuczak Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions .github/actions/set-cluster-name/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
name: 'Set EKS Test Cluster Name'
description: 'Generate a shortened, standardized EKS test cluster name'
inputs:
test-type:
description: 'Type of test (e.g., smoke, integration)'
required: true
platform:
description: 'Platform variant (e.g., distroless, arm-ubuntu, arm-rhel, arm-al2023, helm, namespace, nightly, manual, or empty for standard)'
required: false
default: ''
test-name:
description: 'Test name from matrix (e.g., basic, managerappframeworkc3)'
required: true
run-id:
description: 'GitHub run ID for uniqueness'
required: true
outputs:
cluster-name:
description: 'The generated cluster name'
value: ${{ steps.generate-name.outputs.cluster_name }}
runs:
using: "composite"
steps:
- name: Generate cluster name
id: generate-name
shell: bash
run: |
TEST_NAME="${{ inputs.test-name }}"

# Shorten long test names
case "$TEST_NAME" in
managerappframeworkc3) TEST_NAME="mgr-appfw-c3" ;;
managerappframeworkm4) TEST_NAME="mgr-appfw-m4" ;;
appframeworksS1) TEST_NAME="appfw-s1" ;;
managersecret) TEST_NAME="mgr-secret" ;;
managermc) TEST_NAME="mgr-mc" ;;
esac

# Build cluster name based on platform
if [ -z "${{ inputs.platform }}" ]; then
# Standard platform (no platform suffix)
CLUSTER_NAME="eks-test-${{ inputs.test-type }}-${TEST_NAME}-${{ inputs.run-id }}"
else
# Platform-specific
CLUSTER_NAME="eks-test-${{ inputs.test-type }}-${{ inputs.platform }}-${TEST_NAME}-${{ inputs.run-id }}"
fi

echo "cluster_name=${CLUSTER_NAME}" >> $GITHUB_OUTPUT
echo "Generated cluster name: ${CLUSTER_NAME}"

14 changes: 11 additions & 3 deletions .github/workflows/arm-AL2023-build-test-push-workflow-AL2023.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,11 +146,19 @@ jobs:
ARM64: "true"
GRAVITON_TESTING: "true"
steps:
- name: Set Test Cluster Name
run: |
echo "TEST_CLUSTER_NAME=eks-integration-test-cluster-${{ matrix.test }}-$GITHUB_RUN_ID" >> $GITHUB_ENV
- name: Chekcout code
uses: actions/checkout@v2
- name: Set Test Cluster Name
id: set-cluster-name
uses: ./.github/actions/set-cluster-name
with:
test-type: smoke
platform: arm-al2023
test-name: ${{ matrix.test }}
run-id: ${{ github.run_id }}
- name: Export cluster name to environment
run: |
echo "TEST_CLUSTER_NAME=${{ steps.set-cluster-name.outputs.cluster-name }}" >> $GITHUB_ENV
- name: Dotenv Action
id: dotenv
uses: falti/dotenv-action@d4d12eaa0e1dd06d5bdc3d7af3bf4c8c93cb5359
Expand Down
14 changes: 11 additions & 3 deletions .github/workflows/arm-AL2023-int-test-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,6 @@ jobs:
ARM64: "true"
GRAVITON_TESTING: "true"
steps:
- name: Set Test Cluster Name
run: |
echo "TEST_CLUSTER_NAME=eks-integration-test-cluster-${{ matrix.test }}-$GITHUB_RUN_ID" >> $GITHUB_ENV
- name: Set Test Cluster Nodes and Parallel Runs
run: >-
if grep -q "appframework" <<< "${{ matrix.test }}"; then
Expand All @@ -105,6 +102,17 @@ jobs:
fi
- name: Checkcout code
uses: actions/checkout@v2
- name: Set Test Cluster Name
id: set-cluster-name
uses: ./.github/actions/set-cluster-name
with:
test-type: integration
platform: arm-al2023
test-name: ${{ matrix.test }}
run-id: ${{ github.run_id }}
- name: Export cluster name to environment
run: |
echo "TEST_CLUSTER_NAME=${{ steps.set-cluster-name.outputs.cluster-name }}" >> $GITHUB_ENV
- name: Dotenv Action
id: dotenv
uses: falti/dotenv-action@d4d12eaa0e1dd06d5bdc3d7af3bf4c8c93cb5359
Expand Down
24 changes: 16 additions & 8 deletions .github/workflows/arm-RHEL-build-test-push-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: ARM RHEL Integration Test WorkFlow
name: ARM RHEL Smoke Test WorkFlow
permissions:
contents: read
packages: write
Expand Down Expand Up @@ -54,7 +54,7 @@ jobs:
export BASE_IMAGE_VERSION=9.5
export IMG=${{ secrets.ECR_REPOSITORY }}/${{ env.SPLUNK_OPERATOR_IMAGE_NAME }}:$GITHUB_SHA
make docker-buildx PLATFORMS=$PLATFORMS BASE_IMAGE=$BASE_IMAGE BASE_IMAGE_VERSION=$BASE_IMAGE_VERSION IMG=$IMG
int-tests-arm-rhel:
smoke-tests-arm-rhel:
strategy:
fail-fast: false
matrix:
Expand All @@ -79,8 +79,8 @@ jobs:
SPLUNK_OPERATOR_IMAGE_NAME: splunk/splunk-operator
SPLUNK_OPERATOR_IMAGE_FILENAME: splunk-operator
TEST_FOCUS: "${{ matrix.test }}"
# This regex matches any string not containing integration keyword
TEST_TO_SKIP: "^(?:[^i]+|i(?:$|[^n]|n(?:$|[^t]|t(?:$|[^e]|e(?:$|[^g]|g(?:$|[^r]|r(?:$|[^a]|a(?:$|[^t]|t(?:$|[^i]|i(?:$|[^o]|o(?:$|[^n])))))))))))*$"
# This regex matches any string not containing smoke keyword
TEST_TO_SKIP: "^(?:[^s]+|s(?:$|[^m]|m(?:$|[^o]|o(?:$|[^k]|k(?:$|[^e])))))*$"
TEST_CLUSTER_PLATFORM: eks
EKS_VPC_PRIVATE_SUBNET_STRING: ${{ secrets.EKS_VPC_PRIVATE_SUBNET_STRING }}
EKS_VPC_PUBLIC_SUBNET_STRING: ${{ secrets.EKS_VPC_PUBLIC_SUBNET_STRING }}
Expand All @@ -94,9 +94,6 @@ jobs:
ARM64: "true"
GRAVITON_TESTING: "true"
steps:
- name: Set Test Cluster Name
run: |
echo "TEST_CLUSTER_NAME=eks-integration-test-cluster-${{ matrix.test }}-$GITHUB_RUN_ID" >> $GITHUB_ENV
- name: Set Test Cluster Nodes and Parallel Runs
run: >-
if grep -q "appframework" <<< "${{ matrix.test }}"; then
Expand All @@ -105,6 +102,17 @@ jobs:
fi
- name: Checkcout code
uses: actions/checkout@v2
- name: Set Test Cluster Name
id: set-cluster-name
uses: ./.github/actions/set-cluster-name
with:
test-type: smoke
platform: arm-rhel
test-name: ${{ matrix.test }}
run-id: ${{ github.run_id }}
- name: Export cluster name to environment
run: |
echo "TEST_CLUSTER_NAME=${{ steps.set-cluster-name.outputs.cluster-name }}" >> $GITHUB_ENV
- name: Dotenv Action
id: dotenv
uses: falti/dotenv-action@d4d12eaa0e1dd06d5bdc3d7af3bf4c8c93cb5359
Expand Down Expand Up @@ -180,7 +188,7 @@ jobs:
sudo snap install kustomize
mkdir -p ./bin
cp /snap/bin/kustomize ./bin/kustomize
- name: Run Integration test
- name: Run smoke test
run: |
make int-test
- name: Collect Test Logs
Expand Down
14 changes: 11 additions & 3 deletions .github/workflows/arm-RHEL-int-test-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,6 @@ jobs:
ARM64: "true"
GRAVITON_TESTING: "true"
steps:
- name: Set Test Cluster Name
run: |
echo "TEST_CLUSTER_NAME=eks-integration-test-cluster-${{ matrix.test }}-$GITHUB_RUN_ID" >> $GITHUB_ENV
- name: Set Test Cluster Nodes and Parallel Runs
run: >-
if grep -q "appframework" <<< "${{ matrix.test }}"; then
Expand All @@ -105,6 +102,17 @@ jobs:
fi
- name: Checkcout code
uses: actions/checkout@v2
- name: Set Test Cluster Name
id: set-cluster-name
uses: ./.github/actions/set-cluster-name
with:
test-type: integration
platform: arm-rhel
test-name: ${{ matrix.test }}
run-id: ${{ github.run_id }}
- name: Export cluster name to environment
run: |
echo "TEST_CLUSTER_NAME=${{ steps.set-cluster-name.outputs.cluster-name }}" >> $GITHUB_ENV
- name: Dotenv Action
id: dotenv
uses: falti/dotenv-action@d4d12eaa0e1dd06d5bdc3d7af3bf4c8c93cb5359
Expand Down
14 changes: 11 additions & 3 deletions .github/workflows/arm-Ubuntu-build-test-push-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,11 +146,19 @@ jobs:
ARM64: "true"
GRAVITON_TESTING: "true"
steps:
- name: Set Test Cluster Name
run: |
echo "TEST_CLUSTER_NAME=eks-integration-test-cluster-${{ matrix.test }}-$GITHUB_RUN_ID" >> $GITHUB_ENV
- name: Chekcout code
uses: actions/checkout@v2
- name: Set Test Cluster Name
id: set-cluster-name
uses: ./.github/actions/set-cluster-name
with:
test-type: smoke
platform: arm-ubuntu
test-name: ${{ matrix.test }}
run-id: ${{ github.run_id }}
- name: Export cluster name to environment
run: |
echo "TEST_CLUSTER_NAME=${{ steps.set-cluster-name.outputs.cluster-name }}" >> $GITHUB_ENV
- name: Dotenv Action
id: dotenv
uses: falti/dotenv-action@d4d12eaa0e1dd06d5bdc3d7af3bf4c8c93cb5359
Expand Down
14 changes: 11 additions & 3 deletions .github/workflows/arm-Ubuntu-int-test-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,6 @@ jobs:
ARM64: "true"
GRAVITON_TESTING: "true"
steps:
- name: Set Test Cluster Name
run: |
echo "TEST_CLUSTER_NAME=eks-integration-test-cluster-${{ matrix.test }}-$GITHUB_RUN_ID" >> $GITHUB_ENV
- name: Set Test Cluster Nodes and Parallel Runs
run: >-
if grep -q "appframework" <<< "${{ matrix.test }}"; then
Expand All @@ -105,6 +102,17 @@ jobs:
fi
- name: Checkcout code
uses: actions/checkout@v2
- name: Set Test Cluster Name
id: set-cluster-name
uses: ./.github/actions/set-cluster-name
with:
test-type: integration
platform: arm-ubuntu
test-name: ${{ matrix.test }}
run-id: ${{ github.run_id }}
- name: Export cluster name to environment
run: |
echo "TEST_CLUSTER_NAME=${{ steps.set-cluster-name.outputs.cluster-name }}" >> $GITHUB_ENV
- name: Dotenv Action
id: dotenv
uses: falti/dotenv-action@d4d12eaa0e1dd06d5bdc3d7af3bf4c8c93cb5359
Expand Down
13 changes: 10 additions & 3 deletions .github/workflows/build-test-push-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,11 +190,18 @@ jobs:
CLUSTER_WIDE: "true"
DEPLOYMENT_TYPE: ""
steps:
- name: Set Test Cluster Name
run: |
echo "TEST_CLUSTER_NAME=eks-integration-test-cluster-${{ matrix.test }}-$GITHUB_RUN_ID" >> $GITHUB_ENV
- name: Chekcout code
uses: actions/checkout@v2
- name: Set Test Cluster Name
id: set-cluster-name
uses: ./.github/actions/set-cluster-name
with:
test-type: smoke
test-name: ${{ matrix.test }}
run-id: ${{ github.run_id }}
- name: Export cluster name to environment
run: |
echo "TEST_CLUSTER_NAME=${{ steps.set-cluster-name.outputs.cluster-name }}" >> $GITHUB_ENV
- name: Dotenv Action
id: dotenv
uses: falti/dotenv-action@d4d12eaa0e1dd06d5bdc3d7af3bf4c8c93cb5359
Expand Down
14 changes: 11 additions & 3 deletions .github/workflows/distroless-build-test-push-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,11 +191,19 @@ jobs:
CLUSTER_WIDE: "true"
DEPLOYMENT_TYPE: ""
steps:
- name: Set Test Cluster Name
run: |
echo "TEST_CLUSTER_NAME=eks-integration-test-cluster-${{ matrix.test }}-$GITHUB_RUN_ID" >> $GITHUB_ENV
- name: Chekcout code
uses: actions/checkout@v2
- name: Set Test Cluster Name
id: set-cluster-name
uses: ./.github/actions/set-cluster-name
with:
test-type: smoke
platform: distroless
test-name: ${{ matrix.test }}
run-id: ${{ github.run_id }}
- name: Export cluster name to environment
run: |
echo "TEST_CLUSTER_NAME=${{ steps.set-cluster-name.outputs.cluster-name }}" >> $GITHUB_ENV
- name: Dotenv Action
id: dotenv
uses: falti/dotenv-action@d4d12eaa0e1dd06d5bdc3d7af3bf4c8c93cb5359
Expand Down
14 changes: 11 additions & 3 deletions .github/workflows/distroless-int-test-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,6 @@ jobs:
CLUSTER_WIDE: "true"
DEPLOYMENT_TYPE: ""
steps:
- name: Set Test Cluster Name
run: |
echo "TEST_CLUSTER_NAME=eks-integration-test-cluster-${{ matrix.test }}-$GITHUB_RUN_ID" >> $GITHUB_ENV
- name: Set Test Cluster Nodes and Parallel Runs
run: >-
if grep -q "appframework" <<< "${{ matrix.test }}"; then
Expand All @@ -99,6 +96,17 @@ jobs:
fi
- name: Checkcout code
uses: actions/checkout@v2
- name: Set Test Cluster Name
id: set-cluster-name
uses: ./.github/actions/set-cluster-name
with:
test-type: integration
platform: distroless
test-name: ${{ matrix.test }}
run-id: ${{ github.run_id }}
- name: Export cluster name to environment
run: |
echo "TEST_CLUSTER_NAME=${{ steps.set-cluster-name.outputs.cluster-name }}" >> $GITHUB_ENV
- name: Dotenv Action
id: dotenv
uses: falti/dotenv-action@d4d12eaa0e1dd06d5bdc3d7af3bf4c8c93cb5359
Expand Down
16 changes: 11 additions & 5 deletions .github/workflows/helm-test-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,6 @@ jobs:
run: |
make docker-buildx IMG=${{ secrets.ECR_REPOSITORY }}/${{ env.SPLUNK_OPERATOR_IMAGE_NAME }}:$GITHUB_SHA
int-tests:
strategy:
fail-fast: false
runs-on: ubuntu-latest
needs: build-operator-image
env:
Expand All @@ -72,9 +70,6 @@ jobs:
- name: Checking YQ installation
run: |
yq --help
- name: Set Test Cluster Name
run: |
echo "TEST_CLUSTER_NAME=eks-integration-test-cluster-${{ matrix.test }}-$GITHUB_RUN_ID" >> $GITHUB_ENV
- name: Set Test Cluster Nodes and Parallel Runs
run: >-
if grep -q "appframework" <<< "${{ matrix.test }}"; then
Expand All @@ -83,6 +78,17 @@ jobs:
fi
- name: Chekcout code
uses: actions/checkout@v2
- name: Set Test Cluster Name
id: set-cluster-name
uses: ./.github/actions/set-cluster-name
with:
test-type: integration
platform: helm
test-name: ${{ matrix.test }}
run-id: ${{ github.run_id }}
- name: Export cluster name to environment
run: |
echo "TEST_CLUSTER_NAME=${{ steps.set-cluster-name.outputs.cluster-name }}" >> $GITHUB_ENV
- name: Dotenv Action
id: dotenv
uses: falti/dotenv-action@d4d12eaa0e1dd06d5bdc3d7af3bf4c8c93cb5359
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/int-test-azure-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,6 @@ jobs:
inlineScript: |
az aks update -n ${{ env.TEST_CLUSTER_NAME }} -g ${{ secrets.AZURE_RESOURCE_GROUP_NAME }} --attach-acr ${{ secrets.AZURE_CONTAINER_REGISTRY }}
int-tests-appframeworkazure:
strategy:
fail-fast: false
runs-on: ubuntu-latest
needs: setup-aks-cluster
env:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/int-test-gcp-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@ jobs:
SPLUNK_ENTERPRISE_RELEASE_IMAGE: ${{ secrets.SPLUNK_ENTERPRISE_RELEASE_IMAGE }}
SPLUNK_OPERATOR_IMAGE_NAME: splunk/splunk-operator
SPLUNK_OPERATOR_IMAGE_FILENAME: splunk-operator
TEST_TO_SKIP: "^(?:[^s]+|s(?:$|[^m]|m(?:$|[^o]|o(?:$|[^k]|k(?:$|[^e])))))*$"
# This regex matches any string not containing integration keyword
TEST_TO_SKIP: "^(?:[^i]+|i(?:$|[^n]|n(?:$|[^t]|t(?:$|[^e]|e(?:$|[^g]|g(?:$|[^r]|r(?:$|[^a]|a(?:$|[^t]|t(?:$|[^i]|i(?:$|[^o]|o(?:$|[^n])))))))))))*$"
Copy link
Collaborator

@rlieberman-splunk rlieberman-splunk Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine to keep but I actually don't think it's doing anything. The gcp test cases with the keywords in the test_focus field do not use smoke and integration, so no specific tests are skipped or included here besides the test_focus. Example: https://github.com/splunk/splunk-operator/blob/main/test/appframework_gcp/c3/appframework_gcs_test.go#L94

TEST_BUCKET: ${{ secrets.TEST_BUCKET }}
TEST_S3_BUCKET: ${{ secrets.TEST_BUCKET }}
TEST_INDEXES_S3_BUCKET: ${{ secrets.TEST_INDEXES_S3_BUCKET }}
Expand Down
13 changes: 10 additions & 3 deletions .github/workflows/int-test-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,6 @@ jobs:
CLUSTER_WIDE: "true"
DEPLOYMENT_TYPE: ""
steps:
- name: Set Test Cluster Name
run: |
echo "TEST_CLUSTER_NAME=eks-integration-test-cluster-${{ matrix.test }}-$GITHUB_RUN_ID" >> $GITHUB_ENV
- name: Set Test Cluster Nodes and Parallel Runs
run: >-
if grep -q "appframework" <<< "${{ matrix.test }}"; then
Expand All @@ -95,6 +92,16 @@ jobs:
fi
- name: Checkcout code
uses: actions/checkout@v2
- name: Set Test Cluster Name
id: set-cluster-name
uses: ./.github/actions/set-cluster-name
with:
test-type: integration
test-name: ${{ matrix.test }}
run-id: ${{ github.run_id }}
- name: Export cluster name to environment
run: |
echo "TEST_CLUSTER_NAME=${{ steps.set-cluster-name.outputs.cluster-name }}" >> $GITHUB_ENV
- name: Dotenv Action
id: dotenv
uses: falti/dotenv-action@d4d12eaa0e1dd06d5bdc3d7af3bf4c8c93cb5359
Expand Down
Loading
Loading