Skip to content

CSPL-1598: Delete apps from app directory while app installation is in progress #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
smohan-splunk merged 3 commits into from
May 31, 2022
Merged

CSPL-1598: Delete apps from app directory while app installation is in progress #800

smohan-splunk merged 3 commits into from
May 31, 2022

Conversation

@tpereirasplunk
Copy link
Contributor

@tpereirasplunk tpereirasplunk commented May 23, 2022 •
edited
Loading

S1, C3, M4 automation test covering the following case:

  • Create and apply CR Spec with local scope for installation (so 1 app install at a time) and App Source containing lots of Apps, with the biggest size as possible.
  • Wait for app installation to start
  • Delete all the apps from app-directory while installation is going on
  • Wait for Operator Pod to copy back the apps in app directory
  • Verify all apps are eventually installed.

Clean run: https://github.com/splunk/splunk-operator/actions/runs/2398809065

tpereirasplunk
tpereirasplunk commented May 23, 2022
View reviewed changes
@tpereirasplunk tpereirasplunk force-pushed the CSPL-1598 branch 14 times, most recently from 2b2f46e to 25c8ebc Compare May 26, 2022 23:57
pdhanoya-splunk
pdhanoya-splunk reviewed May 27, 2022
View reviewed changes
tpereirasplunk
tpereirasplunk commented May 27, 2022
View reviewed changes
jambrosiano
jambrosiano reviewed May 27, 2022
View reviewed changes
jambrosiano
jambrosiano reviewed May 27, 2022
View reviewed changes
jambrosiano
jambrosiano reviewed May 27, 2022
View reviewed changes
@tpereirasplunk tpereirasplunk changed the title CSPL-1598: Delete apps from init-apps while app installation is in progress CSPL-1598: Delete apps from app directory while app installation is in progress May 27, 2022
@jambrosiano jambrosiano self-requested a review May 27, 2022 22:54
pdhanoya-splunk
pdhanoya-splunk approved these changes May 28, 2022
View reviewed changes
test/testenv/util.go
ns = testcaseEnvInst.GetName()
} else {
ns = "splunk-operator"
}
Copy link
Contributor

@pdhanoya-splunk pdhanoya-splunk May 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: We might as well cleanup this piece of code. Line 880:883

@smohan-splunk smohan-splunk merged commit 65a074f into feature-appframework May 31, 2022
@patrykw-splunk patrykw-splunk deleted the CSPL-1598 branch December 5, 2025 13:34
@patrykw-splunk patrykw-splunk restored the CSPL-1598 branch December 5, 2025 13:35
@patrykw-splunk patrykw-splunk deleted the CSPL-1598 branch December 5, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smohan-splunk smohan-splunk Awaiting requested review from smohan-splunk

2 more reviewers

@jambrosiano jambrosiano jambrosiano approved these changes

@pdhanoya-splunk pdhanoya-splunk pdhanoya-splunk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tpereirasplunk @jambrosiano @pdhanoya-splunk @smohan-splunk