Skip to content

Commit e973eb3

Browse files
author
David Noble
committed
Added TODOs for bugs left unaddressed in the last commit
1 parent 9550734 commit e973eb3

File tree

4 files changed

+12
-4
lines changed

4 files changed

+12
-4
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# [commands.conf]($SPLUNK_HOME/etc/system/README/commands.conf.spec)
22
[defaults]
3-
supports_getinfo = true
43

54
[%(command.lower()]
65
filename = %(command.lower()).py
6+
supports_getinfo = true

setup.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ def run(self):
5757
cov.stop()
5858
cov.html_report(directory='coverage_report')
5959

60+
6061
class TestCommand(Command):
6162
"""setup.py command to run the whole test suite."""
6263
description = "Run test full test suite."

splunklib/searchcommands/__init__.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,14 @@ class sets this value unconditionally. You cannot override it.
133133
2. [Search command style guide](http://docs.splunk.com/Documentation/Splunk/6.0/Search/Searchcommandstyleguide)
134134
135135
"""
136+
137+
# TODO: Do not use [defaults] stanza in commands.conf
138+
# It doesn't work as advertised. Make sure the ERD/PRD/User documentation is
139+
# updated. The source code already is.
140+
141+
# TODO: Multi-line message headers are incorrectly formatted in Splunk Web UI
142+
# What should we be using as a newline terminator? Try url encoding.
143+
136144
from __future__ import absolute_import
137145

138146
from .decorators import *

splunklib/searchcommands/search_command.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -184,10 +184,9 @@ def process(self, args=argv, input_file=stdin, output_file=stdout):
184184
message = (
185185
'Static configuration is unsupported. Please configure this '
186186
'command as follows in default/commands.conf:\n\n'
187-
'[default]\n'
188-
'supports_getinfo = true\n'
189187
'[%s]\n'
190-
'filename = %s' %
188+
'filename = %s\n' %
189+
'supports_getinfo = true'
191190
(type(self).name, path.basename(argv[0])))
192191
self.messages.append('error_message', message)
193192
self.messages.write(output_file)

0 commit comments

Comments
 (0)