Added support for better webhooks and victorops for saved searches notifications

[pjayala]

No description provided.

[rrossetti-splunk]

@pjayala Can you fix the lint error?

Error: splunk/resource_splunk_saved_searches_test.go:517:13: undefined: newSavedSearchesVictorops (typecheck)

[pjayala]

@pjayala Can you fix the lint error?

Error: splunk/resource_splunk_saved_searches_test.go:517:13: undefined: newSavedSearchesVictorops (typecheck)

Done!

[rrossetti-splunk]

@pjayala Thanks for fixing Lint error, but a test is failing:

RUN TestAccSplunkSavedSearches
testing.go:684: Step 7 error: Check failed: Check 11/22 error: splunk_saved_searches.test: Attribute 'action_victorops_param_inactive_polls' expected "10", got ""
--- FAIL: TestAccSplunkSavedSearches (1.36s)

[pjayala]

@pjayala Thanks for fixing Lint error, but a test is failing:

RUN TestAccSplunkSavedSearches
testing.go:684: Step 7 error: Check failed: Check 11/22 error: splunk_saved_searches.test: Attribute 'action_victorops_param_inactive_polls' expected "10", got ""
--- FAIL: TestAccSplunkSavedSearches (1.36s)

Thanks, I have fixed tests for victorops

[rrossetti-splunk]

@pjayala Thanks for fixing Lint error, but a test is failing:

RUN TestAccSplunkSavedSearches
testing.go:684: Step 7 error: Check failed: Check 11/22 error: splunk_saved_searches.test: Attribute 'action_victorops_param_inactive_polls' expected "10", got ""
--- FAIL: TestAccSplunkSavedSearches (1.36s)

Thanks, I have fixed tests for victorops

Looks like there is a typo in the test "TestAccSplunkSavedSearches"

RUN TestAccSplunkSavedSearches
testing.go:684: Step 8 error: config is invalid: 2 problems:

    - Unsupported argument: An argument named "action_better_webhook_param_credetials" is not expected here. Did you mean "action_better_webhook_param_credential"?

[pjayala]

@rrossetti-splunk Thanks, I fixed the typo

[rrossetti-splunk]

@rrossetti-splunk Thanks, I fixed the typo

New release including the change is out - 1.4.33
Thanks for your help and patience with this!
https://registry.terraform.io/providers/splunk/splunk/latest