fix: handle nil values and URL-encode lookup table file contents#220
Merged
rrossetti-splunk merged 1 commit intosplunk:masterfrom Mar 12, 2026
Merged
Conversation
- Convert nil values in file_contents to empty strings before JSON marshaling to prevent sending null values to the Splunk API, which causes "Unable to save the lookup" errors. - Use url.Values.Encode() instead of fmt.Sprintf for form body parameters in Create, Read, and Update operations to properly URL-encode special characters in the JSON contents payload.
rrossetti-splunk
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
file_contentsto empty strings before JSON marshaling to prevent sendingnullvalues to the Splunk API, which causes500 - Unable to save the lookuperrors.url.Values.Encode()instead offmt.Sprintffor form body parameters in Create, Read, and Update operations to properly URL-encode special characters (brackets, quotes, etc.) in the JSON contents payload.Context
When
file_contentscontains rows with trailing empty fields (e.g. CSV rows where the last column is empty), Terraform's SDK represents these asnilinterface values. The previous code passed these directly tojson.Marshal, which serialized them asnull— causing Splunk's lookup edit API to reject the request with a 500 error.Additionally, the form body was built using
fmt.Sprintfwithout URL-encoding thecontentsparameter. Sincecontentsis a JSON string containing characters like[,],", and,, these could break the form parsing on the server side.Test plan