Adding the support to override the defaul the observability api url #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In one of our example, instead of using api.<REALM>.signalfx.com we are making use of external-api.<REALM>.signalfx.com api URL. So in order to achieve it, following support is added in which if apiUrl is passed in providers.tf, it wil take precedence otherwise default one will be used
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In one of our example, instead of using
api.<REALM>.signalfx.comwe are making use ofexternal-api.<REALM>.signalfx.comapi URL. So in order to achieve it, following support is added in which if apiUrl is passed in providers.tf, it wil take precedence otherwise default one will be usedResolves #ISSUE_NUMBER
Before the change?
After the change?
Pull request checklist
make testacc), and pasted in this PR (for bug fixes / features)Acceptance Test Output
Does this introduce a breaking change?