Skip to content

Draft: Rate limit resource_victorops_routing_key.go #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Draft: Rate limit resource_victorops_routing_key.go #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions victorops/resource_victorops_routing_key.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
package victorops

import (
"context"
"fmt"

"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
"github.com/victorops/go-victorops/victorops"
"golang.org/x/time/rate"
)

// Create a global rate limiter instance.
var limiter = rate.NewLimiter(2, 1) // 2 tokens per second, with a burst size of 1

func resourceRoutingKey() *schema.Resource {
return &schema.Resource{
Create: resourceRoutingKeyCreate,
Expand Down Expand Up @@ -47,7 +51,12 @@ func resourceRoutingKeyCreate(d *schema.ResourceData, m interface{}) error {
Targets: targets,
}

// Make the request
// Wait for the rate limiter before making the request
err := limiter.Wait(context.Background())
if err != nil {
return err
}

newRoutingKey, requestDetails, err := config.VictorOpsClient.CreateRoutingKey(routingKey)
if err != nil {
return err
Expand All @@ -64,6 +73,12 @@ func resourceRoutingKeyCreate(d *schema.ResourceData, m interface{}) error {
func resourceRoutingKeyRead(d *schema.ResourceData, m interface{}) error {
config := m.(Config)

// Wait for the rate limiter before making the request
err := limiter.Wait(context.Background())
if err != nil {
return err
}

rk, _, err := config.VictorOpsClient.GetRoutingKey(d.Get("name").(string))
if err != nil {
return err
Expand All @@ -73,8 +88,6 @@ func resourceRoutingKeyRead(d *schema.ResourceData, m interface{}) error {
d.SetId("")
} else {
d.SetId(rk.RoutingKey)

// Convert the response targets to an array of strings that can be compared
targets := []string{}
for _, target := range rk.Targets {
targets = append(targets, target.PolicySlug)
Expand Down