Conversation
Introduced espn_mbb_team_current_roster and espn_nba_team_current_roster functions for retrieving current team rosters. Added nbagl_live_boxscore and nbagl_live_pbp functions for NBA G-League live data. Updated documentation, NAMESPACE, and installation instructions to use pak. Improved robustness in nba_teams and conference parsing, and updated utility headers and endpoints.
Introduced new skip helper functions for conditional test execution based on environment variables. Updated ESPN MBB and NBA test files to use skip_espn_test and replaced expect_equal with expect_in for column checks to allow for flexible column ordering. Also updated documentation to include new team_current_roster and G-League live functions in related links.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedToo many files! 88 files out of 238 files are above the max files limit of 150. You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This pull request introduces new roster retrieval functions for NBA and men's college basketball, adds G-League live data support, improves test infrastructure, and includes various bug fixes and enhancements across the codebase.
Changes:
- Added
espn_mbb_team_current_rosterandespn_nba_team_current_rosterfunctions to retrieve current team rosters from ESPN - Added
nbagl_live_pbpandnbagl_live_boxscorefunctions for G-League live data - Enhanced test infrastructure with conditional skip functions for different data sources
- Fixed
most_recent_mbb_seasonlogic and improved error handling innba_teams - Updated documentation, metadata, and installation recommendations
Reviewed changes
Copilot reviewed 238 out of 238 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| R/espn_nba_data.R | Added jersey number mapping and new espn_nba_team_current_roster function |
| R/espn_mbb_data.R | Added jersey number mapping and new espn_mbb_team_current_roster function |
| R/nbagl_pbp.R | Added nbagl_live_pbp and nbagl_live_boxscore functions for G-League live data |
| R/utils.R | Fixed most_recent_mbb_season logic to use >= instead of > |
| R/utils_nba_stats.R | Added nbagl_live_endpoint, updated headers, added playbyplayv3 endpoint |
| R/nba_stats_team.R | Improved error handling and robustness with dplyr::any_of |
| tests/testthat/helper-skip.R | Added skip functions for ESPN, NBA Stats, G-League, and NCAA tests |
| tests/testthat/test-*.R | Added skip function calls and updated assertions to use expect_in |
| DESCRIPTION | Updated R version requirement to 4.1.0 and added ORCID |
| NAMESPACE | Exported new functions |
| NEWS.md | Added version 3.0.0 entry |
| README.Rmd/README.md | Updated installation instructions from pacman to pak |
| inst/CITATION | Updated citation with DOI and journal information |
| man/*.Rd | Documentation for new functions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This pull request introduces several new features, improvements, and updates across the codebase, including the addition of new functions to retrieve current team rosters for both NBA and men's college basketball, enhancements to data extraction and utility functions, and updates to documentation and package metadata. The changes also include compatibility and usability improvements for users and developers.
Major feature additions:
espn_mbb_team_current_rosterandespn_nba_team_current_rosterto retrieve current team rosters from ESPN for men's college basketball and NBA teams, respectively. These functions are now exported and documented for public use. [1] [2] [3] [4]Enhancements and bug fixes:
espn_mbb_game_rostersandespn_nba_game_rostersby mapping thejerseyfield. [1] [2]dplyr::any_ofin column selection and renaming, and enhanced error messaging innba_teams. [1] [2] [3] [4]Utility and API improvements:
playbyplayv3NBA endpoint. [1] [2]most_recent_mbb_seasonto correctly determine the current season based on the current month.Documentation and metadata updates:
pakpackage instead ofpacman, and refreshed example outputs to reflect updated data volumes for recent seasons. [1] [2] [3] [4] [5]NEWS.mdand updated the package metadata to require R >= 4.1.0 and include ORCID for the maintainer. [1] [2] [3]New data exports:
nbagl_live_boxscoreandnbagl_live_pbp.