fix: handle playlists with slashes in their names#2534
Merged
Silverarmor merged 2 commits intospotDL:devfrom Oct 26, 2025
Merged
fix: handle playlists with slashes in their names#2534Silverarmor merged 2 commits intospotDL:devfrom
Silverarmor merged 2 commits intospotDL:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where playlists with slashes in their names would cause FileNotFoundError when creating M3U files. The fix ensures parent directories are created before writing the M3U file.
- Adds directory creation to handle nested paths from playlist names containing slashes
- Prevents FileNotFoundError when the directory structure doesn't exist
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
|
Please stop mentioning me on all platforms. I am human. I have more important things in life to prioritise and my work on spotDL is volunteer hours on top of that. I will get to it when I can, please be patient. |
Silverarmor
approved these changes
Oct 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Fix: handle playlists with slashes in their names
Description
This PR fixes an issue where playlists containing slashes in their names would cause a FileNotFoundError when creating M3U files. The fix works by:
Related Issue
Fixes #2284
Motivation and Context
When a playlist name contained slashes like "init 3 - Neutral/Happy", the sanitize_string function would remove the slashes completely, resulting in filenames like "init 3 - NeutralHappy.m3u8". Additionally, if the directory structure didn't exist, the program would crash with a FileNotFoundError when trying to create the M3U file.
How Has This Been Tested?
Tested on Windows with playlist names containing slashes. The changes ensure that:
Screenshots (if appropriate)
Types of Changes
Checklist