Bundle the dependencies in the jar lib folder instead of shading them #1181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building the dependencies programmatically in the sq-10 branch we need to have a findbugs.xml file per plugin on the classpath. The maven shade plugin only keeps one, so only the core plugin loads. Instead of shading the dependencies we can let the sonar packaging plugin bundle them in the lib folder of the jar. Since the sonar-java-plugin already shades its own dependencies we do not need to bundle its transient dependencies, this makes the final jar significantly smaller in particular because the ECJ jar is quite large at around 10Mo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the dependencies programmatically in the sq-10 branch we need to have a
findbugs.xmlfile per plugin on the classpath. The maven shade plugin only keeps one, so only the core plugin loads. Instead of shading the dependencies we can let the sonar packaging plugin bundle them in the lib folder of the jar.Since the sonar-java-plugin already shades its own dependencies we do not need to bundle its transient dependencies, this makes the final jar significantly smaller in particular because the ECJ jar is quite large at around 10Mo.