Fix --module-version 'testing' compilation error in Maven 4 IT builds

[Copilot]

• Fix bad value for --module-version option: 'testing' error in Maven 4 IT builds
  • Changed version from testing to 1.0 in all src/it/**/*.xml and src/it-tools/**/*.xml files
  • Updated src/it-tools/prime/verify.groovy: prime-testing.jar → prime-1.0.jar
  • Updated src/it-tools/build-tools/verify.groovy: build-tools-testing.jar → build-tools-1.0.jar
• Fix sarif-2 IT test NPE: added null check for artifactLocation in both SpotBugsMojo.groovy and sarif-2/verify.groovy
• Fix Maven 4 plugin parameter warnings in IT POMs:
  • Removed deprecated <force>true</force> from maven-clean-plugin 4.x config in common.xml, build-tools/pom.xml, empty/pom.xml, noClassOk/pom.xml, skipEmpty/pom.xml, check-no-missing-classes/pom.xml
  • Replaced deprecated <debug>false</debug> with <debuglevel>none</debuglevel> in maven-compiler-plugin 4.x config in common.xml and build-tools/pom.xml

[hazendaz]

@copilot Now it fails far earlier for all integration tests

64
Error: The following builds failed:
Error: * prime/pom.xml
Error: * build-tools/pom.xml

[Copilot]

@copilot Now it fails far earlier for all integration tests

64
...

Fixed in efcf171 — the verify.groovy scripts for prime and build-tools were checking for JAR files named with the old testing version suffix. Updated:

• prime/verify.groovy: prime-testing.jar → prime-1.0.jar
• build-tools/verify.groovy: build-tools-testing.jar → build-tools-1.0.jar

[hazendaz]

@copilot please look again at maven 4 integration tests as now new error but think you are getting closer. There are also a number of warn8ng due to maven 4 usage that need cleaned up.

[Copilot]

@copilot please look again at maven 4 integration tests as now new error but think you are getting closer. There are also a number of warn8ng due to maven 4 usage that need cleaned up.

Fixed in 527606b:

1. sarif-2 failure (Cannot get property 'artifactLocation' on null object): Added a null check in SpotBugsMojo.groovy before accessing loc.physicalLocation.artifactLocation.uri in the SARIF full-path expansion code. When SpotBugs can't resolve a source file (producing <Unknown>), artifactLocation can be null.

2. Maven 4 warnings cleaned up across common.xml, build-tools/pom.xml, and individual IT POMs:

   • Removed <force>true</force> from maven-clean-plugin 4.x config (parameter was removed in 4.x)
   • Replaced <debug>false</debug> with <debuglevel>none</debuglevel> in maven-compiler-plugin 4.x config (deprecated in 4.x)

[hazendaz]

@copilot last change made it worse.

[Copilot]

@copilot last change made it worse.

Fixed in 10c7fa6. The sarif-2/verify.groovy script had the same NPE at line 38 — loc.physicalLocation.artifactLocation.uri crashes when SpotBugs emits SARIF entries for unresolvable source files (with <Unknown> path, leaving artifactLocation null). Added the same null check to skip those entries in the verify script.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud