feat: pluggable materialization #211
Conversation
| 'https://resolver.confidence.dev/*': [ | ||
| withRouter({ | ||
| '*/v1/flags:resolve': [ | ||
| '*/v1/materialization:readMaterializedOperations|*/v1/materialization:writeMaterializedOperations': [ |
There was a problem hiding this comment.
I think it is reasonable to split these and allow for configuration of timeout individually.
in go and java we allow for env var configuration of this (defaulting to deadline 2 sec for read and 5 sec for write).
There was a problem hiding this comment.
I'm happy to split them. But I'd prefer options rather than env vars? Do we want that? And/or do we also want separate defaults?
There was a problem hiding this comment.
I don't have a strong opinion on wether it is env vars or not. Totally fine with options.
I think it makes sense to allow for separate defaults, considering we are not waiting for the write we can allow for longer timeout there but might want to set the read timeout as long as milliseconds?
Introduces a MaterializationStore interface and makes the Confidence remote materialization store available.