-
Notifications
You must be signed in to change notification settings - Fork 97
feat: Add Issue Comment Reaction functionality #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
src/main/java/com/spotify/github/jackson/CommentReactionContentDeserializer.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
/*- | ||
* -\-\- | ||
* github-api | ||
* -- | ||
* Copyright (C) 2016 - 2020 Spotify AB | ||
* -- | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
* -/-/- | ||
*/ | ||
package com.spotify.github.jackson; | ||
|
||
import com.fasterxml.jackson.core.JsonParser; | ||
import com.fasterxml.jackson.databind.DeserializationContext; | ||
import com.fasterxml.jackson.databind.JsonDeserializer; | ||
import com.spotify.github.v3.comment.CommentReactionContent; | ||
|
||
import java.io.IOException; | ||
/** | ||
* Custom deserializer for {@link CommentReactionContent}. | ||
*/ | ||
public class CommentReactionContentDeserializer extends JsonDeserializer<CommentReactionContent> { | ||
@Override | ||
public CommentReactionContent deserialize(final JsonParser p, final DeserializationContext ctxt) | ||
throws IOException { | ||
String value = p.getText(); | ||
for (CommentReactionContent content : CommentReactionContent.values()) { | ||
if (content.toString().equals(value)) { | ||
return content; | ||
} | ||
} | ||
return null; | ||
} | ||
} |
35 changes: 35 additions & 0 deletions
35
src/main/java/com/spotify/github/jackson/CommentReactionContentSerializer.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
/*- | ||
* -\-\- | ||
* github-api | ||
* -- | ||
* Copyright (C) 2016 - 2020 Spotify AB | ||
* -- | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
* -/-/- | ||
*/ | ||
package com.spotify.github.jackson; | ||
|
||
import com.fasterxml.jackson.core.JsonGenerator; | ||
import com.fasterxml.jackson.databind.JsonSerializer; | ||
import com.fasterxml.jackson.databind.SerializerProvider; | ||
import com.spotify.github.v3.comment.CommentReactionContent; | ||
import java.io.IOException; | ||
/** | ||
* Custom serializer for {@link CommentReactionContent}. | ||
*/ | ||
public class CommentReactionContentSerializer extends JsonSerializer<CommentReactionContent> { | ||
@Override | ||
public void serialize(final CommentReactionContent value, final JsonGenerator gen, final SerializerProvider serializers) throws IOException { | ||
gen.writeString(value.toString()); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 50 additions & 0 deletions
50
src/main/java/com/spotify/github/v3/comment/CommentReaction.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
/*- | ||
* -\-\- | ||
* github-api | ||
* -- | ||
* Copyright (C) 2016 - 2020 Spotify AB | ||
* -- | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
* -/-/- | ||
*/ | ||
package com.spotify.github.v3.comment; | ||
|
||
import com.fasterxml.jackson.databind.annotation.JsonDeserialize; | ||
import com.fasterxml.jackson.databind.annotation.JsonSerialize; | ||
import com.spotify.github.GithubStyle; | ||
import com.spotify.github.UpdateTracking; | ||
import com.spotify.github.v3.User; | ||
import org.immutables.value.Value; | ||
|
||
/** | ||
* Comment reaction object. | ||
* | ||
* <p>See <a | ||
* href="https://docs.github.com/en/rest/reactions/reactions?apiVersion=2022-11-28#about-reactions">About | ||
* GitHub Issue Comment reactions</a> | ||
*/ | ||
@Value.Immutable | ||
@GithubStyle | ||
@JsonSerialize(as = ImmutableCommentReaction.class) | ||
@JsonDeserialize(as = ImmutableCommentReaction.class) | ||
public interface CommentReaction extends UpdateTracking { | ||
|
||
/** Reaction ID. */ | ||
long id(); | ||
|
||
/** Reaction user. */ | ||
User user(); | ||
|
||
/** Reaction content. */ | ||
CommentReactionContent content(); | ||
} |
56 changes: 56 additions & 0 deletions
56
src/main/java/com/spotify/github/v3/comment/CommentReactionContent.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
/*- | ||
* -\-\- | ||
* github-api | ||
* -- | ||
* Copyright (C) 2016 - 2020 Spotify AB | ||
* -- | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
* -/-/- | ||
*/ | ||
package com.spotify.github.v3.comment; | ||
|
||
import com.fasterxml.jackson.databind.annotation.JsonDeserialize; | ||
import com.fasterxml.jackson.databind.annotation.JsonSerialize; | ||
import com.spotify.github.jackson.CommentReactionContentDeserializer; | ||
import com.spotify.github.jackson.CommentReactionContentSerializer; | ||
|
||
/** | ||
* Comment reaction content. | ||
* | ||
* <p>See <a | ||
* href="https://docs.github.com/en/rest/reactions/reactions?apiVersion=2022-11-28#about-reactions">About | ||
* GitHub Issue Comment reactions</a> | ||
*/ | ||
@JsonDeserialize(using = CommentReactionContentDeserializer.class) | ||
@JsonSerialize(using = CommentReactionContentSerializer.class) | ||
public enum CommentReactionContent { | ||
THUMBS_UP("+1"), // 👍 | ||
THUMBS_DOWN("-1"), // 👎 | ||
LAUGH("laugh"), // 😄 | ||
HOORAY("hooray"), // 🎉 | ||
CONFUSED("confused"), // 😕 | ||
HEART("heart"), // ❤️ | ||
ROCKET("rocket"), // 🚀 | ||
EYES("eyes"); // 👀 | ||
|
||
private final String reaction; | ||
|
||
CommentReactionContent(final String reaction) { | ||
this.reaction = reaction; | ||
} | ||
|
||
@Override | ||
public String toString() { | ||
return reaction; | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
going backwards?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was an error so I decided to fix it in this PR too to not publish the wrong version.
Here's more detail about the issue - #214