BazelProtobufBindings for Parsing ActionGraph #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `analysis_v2.proto` to define Protobuf messages for aquery data, including module information, rule definitions, and provider details. - Created a README.md file for the Action Parser, outlining setup instructions and usage for generating Swift bindings from Protobuf definitions. - Implemented unit tests in `ActionParserTests.swift` to validate the parsing of action graph data from Protobuf output, including tests for compiler arguments and action targets. - Added sample Protobuf data file `actions.pb` for testing purposes.
Member
|
Awesome stuff! I need to first finish the refactors we were doing, but at a quick glance it looks exactly what we need. Will be back to this soon |
Member
|
@sean7218 Is it possible to filter this to only include the exact things we're interested in (like the compiler arguments section of swiftcompile/objccompile) or will we always have to ship the entire spec with the tool? |
Contributor
Author
|
Regarding action parser with proto, the aquery output is filtered with SwiftCompile|ObjcCompile, the parsing will only be done for these actions, I don’t know if there is a way to filter down even more such that only the compiler flags remains |
1. remove build.proto and build.pb.swift 2. remove stardoc_output.proto and stardoc_output.pb.swift 3. use Target defined in analysis_v2.proto instead of blaze_query.Target
sean7218
changed the title
rockbruno
approved these changes
Jul 17, 2025
josh-arnold-1
pushed a commit
to josh-arnold-1/sourcekit-bazel-bsp
that referenced
this pull request
Jul 17, 2025
* Add Protobuf Definitions and Action Parser Tests - Introduced `analysis_v2.proto` to define Protobuf messages for aquery data, including module information, rule definitions, and provider details. - Created a README.md file for the Action Parser, outlining setup instructions and usage for generating Swift bindings from Protobuf definitions. - Implemented unit tests in `ActionParserTests.swift` to validate the parsing of action graph data from Protobuf output, including tests for compiler arguments and action targets. - Added sample Protobuf data file `actions.pb` for testing purposes. * Slim down the binding files generated 1. remove build.proto and build.pb.swift 2. remove stardoc_output.proto and stardoc_output.pb.swift 3. use Target defined in analysis_v2.proto instead of blaze_query.Target * updated NOTICE for swift-protobuf * rename ActionParser to BazelProtobufBindings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Protobuf Definitions and BazelProtobufBindings for bazel aquery output proto format
analysis_v2.prototo define Protobuf messages for aquery data, including module information, rule definitions, and provider details.BazelProtobufBindingsTests.swiftto validate the parsing of action graph data from Protobuf output, including tests for compiler arguments and action targets.actions.pbfor testing purposes.