Add refactored handlers for initialize and the shutdown requests #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @mjburghard |
mjburghard
approved these changes
Jul 16, 2025
Comment on lines
+26
to
+28
| /// According to the BSP spec, the server should first receive the `build/shutdown` request, | ||
| /// and then the `onBuildExit` notification. We then exit with different codes depending on | ||
| /// whether the LSP followed the spec correctly or not. |
There was a problem hiding this comment.
Should we also schedule a timer to perform onBuildExit if the notification is never sent to us?
Member
Author
There was a problem hiding this comment.
Will put a note to check this out
josh-arnold-1
pushed a commit
to josh-arnold-1/sourcekit-bazel-bsp
that referenced
this pull request
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another refactor PR, this time for the initialize / shutdown flows. Underlying code is the same, just structured more cleanly and with added tests. The original code is still there just to keep the PRs small; will remove everything once I finish these PRs.