Merged
Conversation
Provide an example commit with changes that seem to fix the regression I was encountering. It seems for some reason buildTarget/prepare is called multiple times for me, so adding back the original caching fixes it... Also, removing "chmod -R 777" seems to have performance benefits for me?
Member
|
Build is red because we need to adjust a test because of the chmod removal, but I'm chatting with Josh debugging regards debugging an issue, so I'll merge this one straight and fix the failure + readjust things directly on master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide an example commit with changes that seem to fix the regression I was encountering.
It seems for some reason buildTarget/prepare is called multiple times for me, so adding back the original caching fixes it...
Also, removing "chmod -R 777" seems to have performance benefits for me?