Migrate action query from text to protobuf parsing#40
Merged
rockbruno merged 10 commits intospotify:mainfrom Aug 18, 2025
Merged
Migrate action query from text to protobuf parsing#40rockbruno merged 10 commits intospotify:mainfrom
rockbruno merged 10 commits intospotify:mainfrom
Conversation
- append command string with "--output proto" - added CompilerArgError for target not found when processing compiler arguments - added back skip `swiftc` and `worker` arguments
- added aquery.pb and aquery_objc.pb as mocking data - updated expected aquery by append "--output proto"
387063a to
1beb0cb
Compare
rockbruno
reviewed
Aug 13, 2025
Member
rockbruno
left a comment
There was a problem hiding this comment.
Nice! Just some smaller points:
Sources/SourceKitBazelBSP/SharedUtils/Shell/CommandRunner.swift
Outdated
Show resolved
Hide resolved
Tests/SourceKitBazelBSPTests/BazelTargetCompilerArgsExtractorTests.swift
Outdated
Show resolved
Hide resolved
Tests/SourceKitBazelBSPTests/BazelTargetCompilerArgsExtractorTests.swift
Show resolved
Hide resolved
Sources/SourceKitBazelBSP/RequestHandlers/SKOptions/CompilerArgumentsProcessor.swift
Outdated
Show resolved
Hide resolved
ba38037 to
cc8f3d9
Compare
rockbruno
reviewed
Aug 14, 2025
Sources/SourceKitBazelBSP/SharedUtils/Shell/CommandRunner.swift
Outdated
Show resolved
Hide resolved
Sources/SourceKitBazelBSP/RequestHandlers/SKOptions/BazelTargetAquerier.swift
Outdated
Show resolved
Hide resolved
Sources/SourceKitBazelBSP/RequestHandlers/SKOptions/CompilerArgumentsProcessor.swift
Outdated
Show resolved
Hide resolved
Sources/SourceKitBazelBSP/RequestHandlers/SKOptions/CompilerArgumentsProcessor.swift
Outdated
Show resolved
Hide resolved
Sources/SourceKitBazelBSP/RequestHandlers/SKOptions/CompilerArgumentsProcessor.swift
Outdated
Show resolved
Hide resolved
rockbruno
approved these changes
Aug 18, 2025
Member
rockbruno
left a comment
There was a problem hiding this comment.
Works perfectly. Thanks Sean!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR modernizes the action query functionality by migrating from plain text parsing to protocol buffer (protobuf) parsing for Bazel action query results. This change improves reliability, type safety, and maintainability of compiler argument extraction.
📝 Key Changes
--output protoflag to all aquery commands to generate protobuf output✨ Benefits
🧪 Testing