Skip to content

Comments

Sets up setup executable rule for integrating into Bazel projects#45

Merged
rockbruno merged 15 commits intospotify:mainfrom
maxwellE:maxwelle/add-bazel-configs-to-tool-code
Aug 19, 2025
Merged

Sets up setup executable rule for integrating into Bazel projects#45
rockbruno merged 15 commits intospotify:mainfrom
maxwellE:maxwelle/add-bazel-configs-to-tool-code

Conversation

@maxwellE
Copy link
Contributor

@maxwellE maxwellE commented Aug 14, 2025

Adds a new executable rule that can be used to set up this tool in any bazel workspace

Signed-off-by: Maxwell Elliott <maxwell@elliott.now>
Signed-off-by: Maxwell Elliott <maxwell@elliott.now>
Signed-off-by: Maxwell Elliott <maxwell@elliott.now>
Signed-off-by: Maxwell Elliott <maxwell@elliott.now>
@maxwellE maxwellE marked this pull request as ready for review August 14, 2025 19:30
@maxwellE maxwellE requested a review from a team as a code owner August 14, 2025 19:30
@maxwellE
Copy link
Contributor Author

Made a PR here for the modulemap issue swiftlang/sourcekit-lsp#2243

Signed-off-by: Maxwell Elliott <maxwell@elliott.now>
Signed-off-by: Maxwell Elliott <maxwell@elliott.now>
Signed-off-by: Maxwell Elliott <maxwell@elliott.now>
Signed-off-by: Maxwell Elliott <maxwell@elliott.now>
Signed-off-by: Maxwell Elliott <maxwell@elliott.now>
@maxwellE maxwellE changed the title Adds Bazel configuration and targets to logic under Sources Sets up setup executable rule for integrating into Bazel projects Aug 15, 2025
Signed-off-by: Maxwell Elliott <maxwell@elliott.now>
Copy link
Member

@rockbruno rockbruno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks Maxwell! Just one (non-blocking) comment

Signed-off-by: Maxwell Elliott <maxwell@elliott.now>
Signed-off-by: Maxwell Elliott <maxwell@elliott.now>
@maxwellE
Copy link
Contributor Author

@rockbruno I need approval on the new GH action for the bazel build validation

@winstondu
Copy link

@maxwellE , before merging, can you update the README as well as the BUILD + Bazelmod in the example folder to demonstrate using the setup rule?

In other words, write out the example use of the setup executable rule.

Signed-off-by: Maxwell Elliott <maxwell@elliott.now>
Signed-off-by: Maxwell Elliott <maxwell@elliott.now>
Signed-off-by: Maxwell Elliott <maxwell@elliott.now>
@maxwellE
Copy link
Contributor Author

@maxwellE , before merging, can you update the README as well as the BUILD + Bazelmod in the example folder to demonstrate using the setup rule?

In other words, write out the example use of the setup executable rule.

This is done

@maxwellE
Copy link
Contributor Author

@rockbruno Need an approval again to get the GH action to run

@rockbruno
Copy link
Member

Thanks Maxwell!

@rockbruno rockbruno merged commit d475906 into spotify:main Aug 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants