Use cquery when getting target information #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockbruno
force-pushed
the
rochab/cquery
branch
2 times, most recently
from
fd6d608 to
b269f6c
Compare
rockbruno
force-pushed
the
rochab/cquery
branch
from
b269f6c to
28fe4b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we care more about what runs under the hood instead of what's in the build file, using cquery will yield more correct results. This also additionally caches better since cqueries uses the
buildconfig while regular queries do not.Required re-generating some of our protos for this to work correctly.
Will follow-up by doing the same to BazelTargetDiscoverer.