Skip to content

Fix indefinite hang on invalid PKCE client_id #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AtomikkuLabs wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix indefinite hang on invalid PKCE client_id #1203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions spotipy/oauth2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,6 +875,27 @@ def get_access_token(self, code=None, check_cache=True):
if self.code_verifier is None or self.code_challenge is None:
self.get_pkce_handshake_parameters()

preflight_payload = {
"client_id": self.client_id,
"grant_type": "authorization_code",
"code": "invalid_code",
"redirect_uri": self.redirect_uri,
"code_verifier": self.code_verifier,
}

preflight_resp = self._session.post(
self.OAUTH_TOKEN_URL,
data=preflight_payload,
headers={"Content-Type": "application/x-www-form-urlencoded"},
timeout=self.requests_timeout,
proxies=self.proxies
)

if preflight_resp.status_code == 400:
body = preflight_resp.json()
if body.get("error") == "invalid_client":
raise SpotifyOauthError("Invalid client_id")

payload = {
"client_id": self.client_id,
"grant_type": "authorization_code",
Expand Down
Loading