Serialize/deserialize maps having numerical keys. Fix #125#209
Open
ancane wants to merge 1 commit intospray:masterfrom
Open
Serialize/deserialize maps having numerical keys. Fix #125#209ancane wants to merge 1 commit intospray:masterfrom
ancane wants to merge 1 commit intospray:masterfrom
Conversation
Member
|
Refs #125 |
|
I had to merge this into an unmanaged jar, but hopefully this gets into release as well. Thanks for the fix. |
Contributor
Author
|
np, thank you. |
|
So guys, when it's gonna be merged? |
jrudolph
reviewed
Oct 23, 2017
Member
jrudolph
left a comment
jrudolph
left a comment
There was a problem hiding this comment.
Hmm, seems weird to me that the signature implies that any kind of keys would be supported when in fact it has stricter constraints on the key format.
Here are two potential alternatives:
- model key entries as
{ "key": ..., "value": ... }which would really support any kind of keys and values - create another type-class to model "Keyable" conversions, which would probably mean providing a bidirectional conversion
K <=> String
ktoso
requested changes
Oct 24, 2017
Member
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
Marking as not ready to merge yet; has review feedback to be addressed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. To me, having numerical keys is handy at times, and having to define custom format every time is cumbersome. So I'd like to suggest to put it here. Thanks.
This is my original work.