Fix invalid pluralization of Spree::RelationType#115
Open
jumski wants to merge 1 commit intospree-contrib:3-0-stablefrom
Open
Fix invalid pluralization of Spree::RelationType#115jumski wants to merge 1 commit intospree-contrib:3-0-stablefrom
jumski wants to merge 1 commit intospree-contrib:3-0-stablefrom
Conversation
Contributor
|
Hi @jumski, this fix works for both |
Author
|
So this should be based on master? Not sure how you propagate this to the stable branch. |
Contributor
|
Hi @jumski, no worries we can cherry-pick it across branches when the failing specs been resolved. |
Author
|
I don't know how to fix this error, seems unrelated to my changes. I have checked out
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this is same stuff as #107 (related to spree/spree#5842)
Please tell if i should base this on master.
Thanks