Skip to content

Fixed product matching and updated readme for promotions#25

Open
imme5150 wants to merge 11 commits intospree-contrib:masterfrom
imme5150:master
Open

Fixed product matching and updated readme for promotions#25
imme5150 wants to merge 11 commits intospree-contrib:masterfrom
imme5150:master

Conversation

@imme5150
Copy link
Contributor

@imme5150 imme5150 commented Mar 1, 2012

It didn't seem to be working for me on my products w/ multiple variants. Works well now.

Also updated the readme for the new promo system

@imme5150
Copy link
Contributor Author

imme5150 commented Mar 1, 2012

I only meant for the first 2 to get in here, guess I should have made my own branch? Don't see a way to remove the last one now.

@BDQ
Copy link
Contributor

BDQ commented Mar 1, 2012

So you only want 90c837f + 4da6f63 merged?

@imme5150
Copy link
Contributor Author

imme5150 commented Mar 1, 2012

Yes, only 90c837f and 4da6f63

a8a99fb changes the functionality, it uses the discount amount as a percentage

@laurens
Copy link
Contributor

laurens commented Aug 20, 2012

+1 for 4da6f63 (readme)

@laurens
Copy link
Contributor

laurens commented Aug 20, 2012

did not review the rest

@peterberkenbosch
Copy link
Member

is this still an issue @laurens // @BDQ ?

@futhr futhr added the stale label Jan 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants