Skip to content

fix: fix code pool concurrent bug #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VLSMB merged 1 commit into from
Mar 6, 2026
Merged

fix: fix code pool concurrent bug #467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 5 additions & 23 deletions ...va/com/alibaba/cloud/ai/dataagent/service/code/impls/AbstractCodePoolExecutorService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;

import java.io.File;
import java.io.IOException;
import java.nio.file.FileVisitResult;
import java.nio.file.Files;
Expand Down Expand Up @@ -303,6 +302,11 @@ private TaskResponse pushTaskQueue(TaskRequest request) throws ExecutionExceptio
return this.runTask(request);
});
this.taskQueue.put(ft);

if (!this.readyCoreContainer.isEmpty() || !this.readyTempContainer.isEmpty()) {
this.popTaskQueue();
}

return ft.get();
}

Expand Down Expand Up @@ -406,28 +410,6 @@ public FileVisitResult postVisitDirectory(@NotNull Path dir, @Nullable IOExcepti
}
}

/**
* Create writable temporary file
* @param tempDir temporary directory
* @param fileName file name
* @throws IOException IO exception
*/
protected void createWritableFile(Path tempDir, String fileName) throws IOException {
File file = new File(tempDir.resolve(fileName).toUri());
if (file.exists()) {
if (!file.setWritable(true, false)) {
throw new IOException("Cannot write to existing file: " + file.getAbsolutePath());
}
return;
}
if (!file.createNewFile()) {
throw new IOException("Failed to create file: " + file.getAbsolutePath());
}
if (!file.setWritable(true, false)) {
throw new IOException("Cannot write to existing file: " + file.getAbsolutePath());
}
}

/**
* Generate unique container name
*/
Expand Down
Loading