feat!: make clientId required for @McpProgress annotation #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: The @McpProgress annotation now requires a clientId parameter. - Remove default empty string from McpProgress.clientId() - Add validation in AsyncProgressSpecification and SyncProgressSpecification constructors - Update all examples and tests to include explicit clientId values - Update README documentation to reflect the required parameter This ensures proper client identification for progress notifications and prevents ambiguous progress handling across multiple MCP clients.
scottslewis
pushed a commit
to scottslewis/mcp-annotations
that referenced
this pull request
Aug 28, 2025
…community#36) BREAKING CHANGE: The @McpProgress annotation now requires a clientId parameter. - Remove default empty string from McpProgress.clientId() - Add validation in AsyncProgressSpecification and SyncProgressSpecification constructors - Update all examples and tests to include explicit clientId values - Update README documentation to reflect the required parameter This ensures proper client identification for progress notifications and prevents ambiguous progress handling across multiple MCP clients.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The @McpProgress annotation now requires a clientId parameter.
This ensures proper client identification for progress notifications and prevents ambiguous progress handling across multiple MCP clients.