feat: improve output schema generation and return type handling #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change @mcptool generateOutputSchema default from true to false - Add documentation for output schema generation behavior - Enhance return type handling in tool method callbacks: * Improve void/Void type detection and handling * Return strings directly without JSON serialization in TEXT mode * Better null value handling with explicit null text content * Serialize complex objects to JSON for text content - Add JsonSchemaGenerator.generateFromType() for better generic type support - Update all tool providers to use type-based schema generation - Add test coverage for: * List return types with complex objects * Output schema generation behavior * String vs complex object serialization * Flux/Mono reactive return types BREAKING CHANGE: @mcptool generateOutputSchema now defaults to false, requiring explicit enablement for output schema generation Signed-off-by: Christian Tzolov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: @mcptool generateOutputSchema now defaults to false, requiring explicit enablement for output schema generation