refactor: fix the return format of CallToolResult #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TheEterna
commented
Oct 4, 2025
TheEterna
commented
- corrected the return format for structured content results, following the MCP protocol.
- fix variable name
- corrected the return format for structured content results, following the MCP protocol. - fix variable name
TheEterna
force-pushed
the
refactor/issue-67-Update-the-AbstractMcpToolMethodCallback.convertValueToCallToolResult
branch
from
2ab3ee2 to
5dbad11
Compare
…ack.convertValueToCallToolResult' of https://github.com/TheEterna/mcp-annotations into refactor/issue-67-Update-the-AbstractMcpToolMethodCallback.convertValueToCallToolResult
LamineMbn
reviewed
Oct 8, 2025
| import io.modelcontextprotocol.spec.McpSchema.CallToolRequest; | ||
| import io.modelcontextprotocol.spec.McpSchema.CallToolResult; | ||
| import io.modelcontextprotocol.spec.McpSchema.*; | ||
| import io.modelcontextprotocol.spec.McpSchema.CallToolResult.*; |
LamineMbn
reviewed
Oct 8, 2025
| if (this.returnMode == ReturnMode.STRUCTURED) { | ||
| String jsonOutput = JsonParser.toJson(result); | ||
| Object structuredOutput = JsonParser.fromJson(jsonOutput, Object.class); | ||
| callToolResultBuilder.structuredContent(structuredOutput); |
There was a problem hiding this comment.
The structured content is available only to JSON so you can do that :
return CallToolResult.builder().structuredContent(structuredOutput).addTextContent(jsonOutput).build();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.