refactor: extract JSON conversion utilities and enhance elicitation support #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tzolov
commented
Oct 8, 2025
tzolov
commented
- Extract convertMapToType methods to JsonParser utility class
- Add convertObjectToMap method to JsonParser for bidirectional conversion
- Add StructuredElicitResult support in elicitation method callbacks
- Update AsyncMcpElicitationMethodCallback to handle Mono
- Update SyncMcpElicitationMethodCallback to handle StructuredElicitResult
- Update providers to filter for StructuredElicitResult return types
- Add StructuredElicitResultBuilder for fluent construction
- Add percentage() convenience method to ProgressSpec
- Add TODO comments for elicitation schema validation
- Update method validation error messages for clarity
- Remove unused Jackson imports from context classes
- Update test expectations for new return type requirements
…upport - Extract convertMapToType methods to JsonParser utility class - Add convertObjectToMap method to JsonParser for bidirectional conversion - Add StructuredElicitResult support in elicitation method callbacks - Update AsyncMcpElicitationMethodCallback to handle Mono<StructuredElicitResult> - Update SyncMcpElicitationMethodCallback to handle StructuredElicitResult - Update providers to filter for StructuredElicitResult return types - Add StructuredElicitResultBuilder for fluent construction - Add percentage() convenience method to ProgressSpec - Add TODO comments for elicitation schema validation - Update method validation error messages for clarity - Remove unused Jackson imports from context classes - Update test expectations for new return type requirements Signed-off-by: Christian Tzolov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.