feat: Add McpRequestContext support to Complete, Prompt, and Resource methods #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… methods Add support for McpSyncRequestContext and McpAsyncRequestContext parameters in Complete, Prompt, and Resource method callbacks, providing a unified interface for accessing MCP request context. - Add McpSyncRequestContext and McpAsyncRequestContext parameter support to AbstractMcpCompleteMethodCallback, AbstractMcpPromptMethodCallback, and AbstractMcpResourceMethodCallback - Implement validation to ensure correct context type matches method synchronicity (sync methods use McpSyncRequestContext, async methods use McpAsyncRequestContext) - Add validation to prevent duplicate request context parameters - Fix @McpProgressToken to properly inject progress token from requests (previously returned null for CompleteRequest) - Update README.md documentation to clarify that McpSyncRequestContext, McpAsyncRequestContext, and @McpProgressToken are supported in Complete, Prompt, Resource, and Tool methods - Add test coverage for request context parameters in sync and async Complete, Prompt, and Resource methods - Add tests for request context with URI variables and arguments - Add validation tests for duplicate and mismatched context types - Add tests for non-null progress token handling Signed-off-by: Christian Tzolov <[email protected]>
Signed-off-by: Christian Tzolov <[email protected]>
Signed-off-by: Christian Tzolov <[email protected]>
Signed-off-by: Christian Tzolov <[email protected]>
Signed-off-by: Christian Tzolov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for McpSyncRequestContext and McpAsyncRequestContext parameters in Complete, Prompt, and Resource method callbacks, providing a unified interface for accessing MCP request context.
Add McpSyncRequestContext and McpAsyncRequestContext parameter support to AbstractMcpCompleteMethodCallback, AbstractMcpPromptMethodCallback, and AbstractMcpResourceMethodCallback
Implement validation to ensure correct context type matches method synchronicity (sync methods use McpSyncRequestContext, async methods use McpAsyncRequestContext)
Add validation to prevent duplicate request context parameters
Fix @McpProgressToken to properly inject progress token from requests (previously returned null for CompleteRequest)
Update README.md documentation to clarify that McpSyncRequestContext, McpAsyncRequestContext, and @McpProgressToken are supported in Complete, Prompt, Resource, and Tool methods
Add test coverage for request context parameters in sync and async Complete, Prompt, and Resource methods
Add tests for request context with URI variables and arguments
Add validation tests for duplicate and mismatched context types
Add tests for non-null progress token handling