This repository was archived by the owner on Jan 19, 2022. It is now read-only.
Add DataSpannerTest annotation#2416
Closed
eddumelendez wants to merge 1 commit intospring-attic:mainfrom
eddumelendez:test_annotations
Closed
Add DataSpannerTest annotation#2416eddumelendez wants to merge 1 commit intospring-attic:mainfrom eddumelendez:test_annotations
eddumelendez wants to merge 1 commit intospring-attic:mainfrom
eddumelendez:test_annotations
Conversation
Contributor
Author
|
/cc @saturnism |
Contributor
|
@eddumelendez thanks for your contribution! We have redesigned our test-support module and this PR will be very useful when we start working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently this configuration is required in order to test a Spanner repository. This PR help to improve that configuration in some way. But previously required some commands to be executed
In order to improve from the test perspective, I think #2357 will help a lot and may this proposal will do the same. Also would like to think about how these initiatives will integrate with
testcontainers, for example, I have a PR https://github.com/testcontainers/testcontainers-java/pull/2690/files which will use docker sdk but it requires additional installation in order to use alpine images so there is an issue requesting images for the other emulators, something similar to spanner.The same can be done for
datasotre,firestoreand I already have something in progress but looks pretty similar. Also, consideringpubsubbut thinking more about it.See gh-2281