Per-request Organization Configuration #1256
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously whenever a request was made to deploy a service, only the target (space) could be changed on a per-request basis. This change adds support for configuring the organization on a per-request basis as well. This change adds a new DeploymentProperty called 'organization' as a peer to 'target'. CloudFoundryOperationsUtils is updated to only have two ways to configure the CloudFoundryOperations, both of which encapsulation of setting both the org and space. The ability to change only the space is removed. The rest of the change is updating and simplifying the rest of the code to remove the branches were the space was optionally set in favor of always using the OperationsUtils passing in the properties where the optionality is centralized. Signed-off-by: Ben Hale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously whenever a request was made to deploy a service, only the target (space) could be changed on a per-request basis. This change adds support for configuring the organization on a per-request basis as well.
This change adds a new
DeploymentPropertycalled 'organization' as a peer to 'target'.CloudFoundryOperationsUtilsis updated to only have two ways to configure theCloudFoundryOperations, both of which encapsulate the setting both the org and space. The ability to change only the space is removed. The rest of the change is updating and simplifying the rest of the code to remove the branches were the space was optionally set in favor of always using theOperationsUtils, passing in the properties where the optionality is centralized.