Skip to content

Use newCachedTreadPool() instead of newSingleThreadExecutor() in InetUtils #1365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Use newCachedTreadPool() instead of newSingleThreadExecutor() in InetUtils #1365

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b581f2
Fix issue 1364
Jul 24, 2024
dc3d597
Add @author tag
Sep 17, 2024
2adf0b8
Update license date
Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions spring-cloud-commons/src/main/java/org/springframework/cloud/commons/util/InetUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2012-2020 the original author or authors.
* Copyright 2012-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -35,10 +35,10 @@

/**
* @author Spencer Gibb
* @author Sergey Tsypanov
*/
public class InetUtils implements Closeable {

// TODO: maybe shutdown the thread pool if it isn't being used?
private final ExecutorService executorService;

private final InetUtilsProperties properties;
Expand All @@ -47,7 +47,7 @@ public class InetUtils implements Closeable {

public InetUtils(final InetUtilsProperties properties) {
this.properties = properties;
this.executorService = Executors.newSingleThreadExecutor(r -> {
this.executorService = Executors.newCachedThreadPool(r -> {
Thread thread = new Thread(r);
thread.setName(InetUtilsProperties.PREFIX);
thread.setDaemon(true);
Expand Down