fix: Adds an empty list to nonFilteredFileExtensions#2367
Merged
spencergibb merged 1 commit intospring-cloud:mainfrom Dec 3, 2025
Merged
fix: Adds an empty list to nonFilteredFileExtensions#2367spencergibb merged 1 commit intospring-cloud:mainfrom
spencergibb merged 1 commit intospring-cloud:mainfrom
Conversation
without this change an NPE is being thrown from Maven Resources Filtering with this change since the list is empty an NPE is no longer thrown fixes spring-cloud#2361 Signed-off-by: Marcin Grzejszczak <marcin@grzejszczak.pl>
marcingrzejszczak
force-pushed
the
fixMavenPlugin
branch
from
e397747 to
cc670df
Compare
spencergibb
reviewed
Dec 3, 2025
Member
spencergibb
left a comment
spencergibb
left a comment
There was a problem hiding this comment.
Is there any way to add a regression test?
Contributor
Author
|
Definitely - #2305 |
Contributor
|
@marcingrzejszczak thanks! I saw this issue, but hadn't had a chance to look into it. Do you plan on adding the tests to this PR? |
marcingrzejszczak
added a commit
to marcingrzejszczak/spring-cloud-contract
that referenced
this pull request
Dec 3, 2025
marcingrzejszczak
added a commit
to marcingrzejszczak/spring-cloud-contract
that referenced
this pull request
Dec 4, 2025
Signed-off-by: Marcin Grzejszczak <marcin@grzejszczak.pl>
|
what version is this fix in now? Is it released yet? |
Contributor
|
It's in 5.0.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
without this change an NPE is being thrown from Maven Resources Filtering with this change since the list is empty an NPE is no longer thrown
fixes #2361