Skip to content

Conversation

breun
Copy link

@breun breun commented Aug 31, 2025

  • Use distribution type only-script and remove maven-wrapper.jar
  • Specify distributionSha256Sum to verify integrity of Maven distribution

Note that the changes to the mvnw* scripts (and the distributionUrl property) can be reproduced by running mvn wrapper:3.3.3:wrapper -Dmaven=3.9.11.

- Use distribution type `only-script` and remove `maven-wrapper.jar`
- Specify `distributionSha256Sum` to verify integrity of Maven distribution

Signed-off-by: Nils Breunese <[email protected]>
@spencergibb
Copy link
Member

Can I ask the purpose of this. All of the spring cloud projects are the same

@breun
Copy link
Author

breun commented Sep 2, 2025

This PR updates the Maven and Maven Wrapper versions from versions which are a couple of years old -- Maven 3.9.0 is from 2023-01-31 and Maven Wrapper 3.1.1 is from 2022-05-08 -- to the current versions.

One of the benefits is that Maven Wrapper's new only-script type no longer requires the binary maven-wrapper.jar to be part of the project repository, and another one is that Maven Wrapper now has a feature to check the integrity of the Maven distribution that is pulled in. There are other bug fixes, new features, etc. as well of course.

I created a PR for this Spring Cloud project first, but I'm willing to create similar PRs for the other ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants