Fix Intermittent Gateway Test Failures Due to Bytecode Reordering#4014
Closed
Kcruz28 wants to merge 1 commit intospring-cloud:mainfrom
Closed
Fix Intermittent Gateway Test Failures Due to Bytecode Reordering#4014Kcruz28 wants to merge 1 commit intospring-cloud:mainfrom
Kcruz28 wants to merge 1 commit intospring-cloud:mainfrom
Conversation
…ationContextRunner and consistent formatting
Member
|
I don't think we need any fixes found by nondex thank you. It's just noise and we aren't having any problems |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Found this while running NonDex on the test suite. When running the test with certain bytecode reordering patterns,
GatewayAutoConfigurationTests.noTokenRelayFilterfails intermittently because the test setup relies onimplicit Spring Application initialization order.
The issue occurs because:
SpringApplication.run(...)with command-line argumentsSolution
Replace
SpringApplication.run(...)with Spring Boot'sReactiveWebApplicationContextRunner,which provides explicit control over auto-configurations and property injection.
SpringApplication.run()initialization with command-line arguments.withConfiguration()to declare which auto-configurations are active.withPropertyValues()to set properties deterministically (not via argument parsing)Why This Matters
This type of issue indicates a hidden dependency on bytecode ordering within the test setup.
By fixing it, we:
nettyHttpClientDefaults,nettyHttpClientConfigured,tokenRelayBeansAreCreated, etc.)Files Changed
GatewayAutoConfigurationTests.javanoTokenRelayFilter()test method to useReactiveWebApplicationContextRunner