Remove spring-boot-properties-migrator from starters (#4022)#4036
Open
amazon7737 wants to merge 1 commit intospring-cloud:4.3.xfrom
Open
Remove spring-boot-properties-migrator from starters (#4022)#4036amazon7737 wants to merge 1 commit intospring-cloud:4.3.xfrom
amazon7737 wants to merge 1 commit intospring-cloud:4.3.xfrom
Conversation
amazon7737
changed the title
amazon7737
force-pushed
the
fix/4022-remove-migrator
branch
from
f2c1498 to
8fe2f48
Compare
|
In #4022 I had only mentioned the new modules, I’m not sure whether it makes sense for the deprecated ones. |
Author
|
@DidierLoiseau I hadn't considered the deprecated modules, thanks for catching that. To prioritize backward compatibility and stability, I agree that we should keep the migrator in the legacy and widely used modules. I will revert the changes for |
As discussed in spring-cloud#4022, removing the temporary properties-migrator dependency from new server-only starter modules (server-webflux and server-webmvc) to avoid unexpected property overrides in production environments. Legacy starter modules (spring-cloud-starter-gateway and spring-cloud-starter-gateway-mvc) will retain the migrator for backward compatibility. Resolves spring-cloud#4022 Signed-off-by: Kangmin Kim <76634341+amazon7737@users.noreply.github.com>
amazon7737
force-pushed
the
fix/4022-remove-migrator
branch
from
8fe2f48 to
014c44e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As discussed in #4022, this PR removes the
spring-boot-properties-migratordependency from the following starter modules:spring-cloud-starter-gateway-server-webfluxspring-cloud-starter-gateway-server-webmvcThese modules should not have a forced dependency on the migrator tool, as it is intended for temporary migration use and can cause unexpected property overrides in production environments (especially with list-based properties like routes).
Related Issue
Fixes #4022
Motivation and Context
The
spring-boot-properties-migratorwas added as a temporary measure (marked with TODO for 5.0). Removing it now aligns with the goal of keeping new starters production-ready and giving users the choice to add it manually if needed, as stated in the release notes.How Has This Been Tested?
mvn dependency:tree../mvnw clean install -DskipTeststo ensure the build remains stable after removal./cc @ryanjbaxter @spencergibb