change deployment delete sequence for integration tests #1754
Conversation
| long startTime = System.currentTimeMillis(); | ||
| if (deployment != null) { | ||
| client.apps().deployments().inNamespace(namespace).resource(deployment).delete(); | ||
|
|
There was a problem hiding this comment.
this really came out of a different thing I am actively working on: I am trying to refactor integration tests, so that they run faster.
While working on my first PR in this direction, I hit an issue where they are still not as fast as I would like them to be. Debugging, showed that the vast majority of time is eaten by the fact that removing deployment and its pods eats the majority of time. This PR fixes that:
- first find the pods of a deployment, remove those (with
--force) - then remove deployment
How much that saves us? In the current tests that I am working on, it shows around 30 seconds saving time for each integration test.
|
@ryanjbaxter ready to be looked, I've compared the times of a few previous runs and running on github is not that impressive of a time reduction, a few minutes, but since we distribute tests, it does not have a "wow" effect. It should be close to that for your internal jenkins though (as far as I understand there you don't run tests in parallel). P.S. Once I am done with all integration tests re-factor, we should see much better times in github also. |
wind57
changed the title
3 participants
No description provided.