drop loading image when its already present #1763
Conversation
|
|
||
| public static void loadWiremock(K3sContainer container) { | ||
| Commons.load(container, WIREMOCK_TAR, WIREMOCK, wiremockVersion()); | ||
| if (!imageAlreadyInK3s(container, WIREMOCK_TAR)) { |
There was a problem hiding this comment.
we did this check in a previous PR for busybox, let's do it for every other image
There was a problem hiding this comment.
Why not just move the check to Commons.load instead?
wind57
changed the title
| .get(0) | ||
| .setImage(imageFromDeployment + ":" + pomVersion()); | ||
| } | ||
| else { |
There was a problem hiding this comment.
I don't recall the history of why we needed this, but we do not anymore. At this point in time the images are already un-tared/downloaded and loaded in k3s, as such we can drop this code
There was a problem hiding this comment.
I think this was needed for Jenkins because on our end we hit threshold limits from Dockerhub inside of K3S. If we pull the images and load them in in the test iself we use our Dockerhub credentials and we don't run into the threshold limits from Dockerhub
There was a problem hiding this comment.
I think I get it, will close this PR cause its a lot easier to make a new one then re-work this one. thx!
| .get(0) | ||
| .setImage(imageFromDeployment + ":" + pomVersion()); | ||
| } | ||
| else { |
There was a problem hiding this comment.
same comment as above
There was a problem hiding this comment.
same comment as above ;)
|
@ryanjbaxter ongoing changes to refactor integration tests. I'm still far from completing it, but its in progress |
|
Got it, when its ready ping me and I will give it a deeper look |
|
I mean, this PR is part of ongoing changes... should have been more explicit, sorry. This one is ready, but more will come, that was my point |
3 participants
No description provided.