Skip to content

Close Fabric8 Client When Context Is Stopped #1780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2024
Merged

Close Fabric8 Client When Context Is Stopped #1780

merged 2 commits into from
Oct 23, 2024

Conversation

@ryanjbaxter
Copy link
Contributor

@ryanjbaxter ryanjbaxter commented Oct 22, 2024

No description provided.

@ryanjbaxter ryanjbaxter force-pushed the closable-fabric8-client branch from 6253909 to febbe07 Compare October 23, 2024 12:06
@ryanjbaxter ryanjbaxter force-pushed the closable-fabric8-client branch from febbe07 to 0adfd8d Compare October 23, 2024 12:10
@ryanjbaxter
Copy link
Contributor Author

ryanjbaxter commented Oct 23, 2024

@wind57 thanks. I am still not really happy with this. Since KubernetesClient implements AutoClosable it seems like the close method should be called automatically. Maybe the timing in which that happens is too late 🤷‍♂️.

@wind57
Copy link
Contributor

wind57 commented Oct 23, 2024

@ryanjbaxter the build is going to fail, the cache download to blame... you might want to push a dummy commit to re-trigger

@ryanjbaxter ryanjbaxter changed the title close fabric 8 client Close Fabric8 Client When Context Is Stopped Oct 23, 2024
@ryanjbaxter ryanjbaxter added this to the 3.1.4 milestone Oct 23, 2024
@ryanjbaxter ryanjbaxter merged commit c6429b3 into spring-cloud:main Oct 23, 2024
14 checks passed
ryanjbaxter pushed a commit that referenced this pull request Oct 23, 2024
@ryanjbaxter
Close Fabric8 Client When Context Is Stopped (#1780)
4d55f69
@wind57 wind57 mentioned this pull request Aug 5, 2025
Closed
@wind57
Copy link
Contributor

wind57 commented Aug 12, 2025

@ryanjbaxter do you remember why we did this? I was trying to find a relevant issue, but no luck : https://github.com/spring-cloud/spring-cloud-kubernetes/issues?q=is%3Aissue%20state%3Aclosed%20created%3A2024-07-01..2024-10-22

The thing is, this fix causes a problem in a different place, in the leader election. a) we have an issue for it b) I can re-produce it. So I'm trying to see what was the underlying problem that triggered this

@ryanjbaxter
Copy link
Contributor Author

ryanjbaxter commented Aug 12, 2025 •
edited
Loading

@wind57 I think it stemmed from this #1773

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@wind57 wind57 wind57 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug

Projects

No open projects
2023.0.4
Status: Done
2024.0.0-RC1
Status: Done

Milestone

3.1.4

Development

Successfully merging this pull request may close these issues.

3 participants

@ryanjbaxter @wind57 @spring-cloud-issues