Fix 1592 empty source on error part 2 #1800
Conversation
| MapPropertySource propertySource = getMapPropertySource(s, env); | ||
| LOG.debug("Adding config map property source " + propertySource.getName()); | ||
| composite.addFirstPropertySource(propertySource); | ||
| if ("true".equals(propertySource.getProperty(Constants.ERROR_PROPERTY))) { |
There was a problem hiding this comment.
the fix should be here and not in the reload. We should not be saving in the environment any property source that was computed on error.
Since reload code, calls this method anyway, it takes care to fix the issue.
There are two parts in the bug:
- (a) when we try to see if we need to reload in the first place
- (b) when we actually reload
In both cases, we call this locate and in both cases we need to skip a property source that was computed on error. Since reload code calls this one, the skipping of the source is done here
There was a problem hiding this comment.
same thing is done in SecretsPropertySourceLocator, everything else is related to changing the tests and proper logging
|
@ryanjbaxter this is ready to be looked at. My previous fix was incomplete and this one wraps up the fix. Thank you for looking into it |
3 participants
No description provided.