Skip to content

try to fix failing tests #1841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanjbaxter merged 2 commits into from
Jan 17, 2025
Merged

try to fix failing tests #1841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7513e67
fix
wind57 Jan 16, 2025
6427977
fix
wind57 Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...s/spring-cloud-kubernetes-fabric8-client-reload/src/main/resources/application-mount.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ spring:
reload:
enabled: true
monitoring-config-maps: true
strategy: shutdown
strategy: refresh
mode: polling
period: 5000
period: 5s
config:
paths:
- /tmp/application.properties
Expand Down
4 changes: 2 additions & 2 deletions ...pring-cloud-kubernetes-fabric8-client-reload/src/main/resources/application-no-mount.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ spring:
reload:
enabled: true
monitoring-config-maps: true
strategy: shutdown
strategy: refresh
mode: polling
period: 5000
period: 5s

4 changes: 2 additions & 2 deletions ...cloud-kubernetes-fabric8-client-reload/src/main/resources/application-with-bootstrap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ spring:
reload:
enabled: true
monitoring-config-maps: true
strategy: shutdown
strategy: refresh
mode: polling
period: 5000
period: 5s

4 changes: 4 additions & 0 deletions ...cloud/kubernetes/fabric8/client/reload/BootstrapEnabledPollingReloadConfigMapMountIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,10 @@ void test() {
configMap.setData(Map.of(Constants.APPLICATION_PROPERTIES, "from.properties.key=as-mount-changed"));
client.configMaps().inNamespace("default").resource(configMap).createOrReplace();

System.out.println("Waiting for reload change to be observed");
Commons.waitForLogStatement("Detected change in config maps/secrets, reload will be triggered", K3S, IMAGE_NAME);
System.out.println("reload change observed");

await().atMost(Duration.ofSeconds(120))
.pollInterval(Duration.ofSeconds(1))
.until(() -> webClient.method(HttpMethod.GET)
Expand Down
2 changes: 2 additions & 0 deletions ...amework/cloud/kubernetes/fabric8/client/reload/ConfigMapMountPollingReloadDelegateIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,8 @@ void test() {
configMap.setData(Map.of(Constants.APPLICATION_PROPERTIES, "from.properties.key=as-mount-changed"));
client.configMaps().inNamespace("default").resource(configMap).createOrReplace();

Commons.waitForLogStatement("Detected change in config maps/secrets, reload will be triggered", K3S, IMAGE_NAME);

await().atMost(Duration.ofSeconds(120))
.pollInterval(Duration.ofSeconds(1))
.until(() -> webClient.method(HttpMethod.GET)
Expand Down
Loading