drop un-used configmap #1880
Merged
drop un-used configmap #1880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
wind57
commented
Feb 22, 2025
| private static final String ISTIO_PILOT_TAR = ISTIO_PILOT.replace('/', '-') + ":" + istioVersion(); | ||
|
|
||
| private static final String KAFKA = "confluentinc/cp-kafka"; | ||
| private static final String KAFKA = "confluentinc/confluent-local"; |
Contributor
Author
There was a problem hiding this comment.
confluent has a new image, that simplifies work that we have to do when when dealing with kafka
wind57
commented
Feb 22, 2025
| deployment.getSpec().getTemplate().getSpec().getContainers().get(0).setImage(imageWithVersion); | ||
|
|
||
| V1Service service = (V1Service) yaml("kafka/kafka-service.yaml"); | ||
| V1ConfigMap configMap = (V1ConfigMap) yaml("kafka/kafka-configmap-startup-script.yaml"); |
Contributor
Author
There was a problem hiding this comment.
we do not need the configmap (and the script it had inside it) to properly run kafka broker
Contributor
There was a problem hiding this comment.
The new image has this?
Contributor
Author
There was a problem hiding this comment.
sort of, its an image that has KRaft enabled, by default, so that we don't have to do the hack we did here
wind57
commented
Feb 22, 2025
| # Another solution is to rename the service. | ||
| enableServiceLinks: false | ||
| volumes: | ||
| - name: kafka-start-config-script |
Contributor
Author
There was a problem hiding this comment.
drop the volume and the script
Contributor
Author
|
@ryanjbaxter simplifying some integration test... ready to be looked at, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.