Fix use-name-as-prefix
#1911
Fix use-name-as-prefix
#1911
Conversation
Fixes gh-1757 Signed-off-by: Julian Nodorp <[email protected]>
| */ | ||
| public final record PrefixContext(Map<String, Object> data, String prefix, String namespace, | ||
| Set<String> propertySourceNames) { | ||
| public final record PrefixContext(MultipleSourcesContainer data, Function<String, String> prefix, String namespace) { |
There was a problem hiding this comment.
this is a breaking change and unfortunately we can't merge breaking changes in main. This only happens on "next major" releases. afaik: next one is at the end of 2025. Ryan can confirm (I'm not a vmware employee), but it seems this would be a NOGO, for the time being at least. What I do is maintain some PRs that are targeted towards next major, but this is not easy, to say the least...
There was a problem hiding this comment.
I have not looked at anything else in the code tbh, will wait for Ryan's input
There was a problem hiding this comment.
I don't think the change I try to make is possible without breaking compatibility. The MultipleSourcesContainer record has a breaking change as well.
Also, as I changed documented behaviour, I think this would be considered a breaking change event if I were able to keep all public interfaces the same.
There was a problem hiding this comment.
We had discussed in the original issue that there would be breaking changes and it would need to wait for a major.
|
We would also need to update this documentation: |
|
can this be closed btw? |
4 participants
Fixes gh-1757