Skip to content

Improve assertions #1938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025
Merged

Improve assertions #1938

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions ...ve/KubernetesInformerReactiveDiscoveryClientAutoConfigurationApplicationContextTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ void discoveryEnabledDefault() {
assertThat(context).hasSingleBean(KubernetesInformerReactiveDiscoveryClient.class);

// simple from commons and ours
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).size().isEqualTo(2);
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).hasSize(2);
assertThat(context).hasSingleBean(KubernetesDiscoveryClientHealthIndicatorInitializer.class);
assertThat(context).hasBean("reactiveIndicatorInitializer");

Expand All @@ -93,7 +93,7 @@ void discoveryEnabledDefaultWithSelectiveNamespaces() {
assertThat(context).hasSingleBean(KubernetesInformerReactiveDiscoveryClient.class);

// simple from commons and ours
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).size().isEqualTo(2);
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).hasSize(2);
assertThat(context).hasSingleBean(KubernetesDiscoveryClientHealthIndicatorInitializer.class);
assertThat(context).hasBean("reactiveIndicatorInitializer");

Expand All @@ -112,7 +112,7 @@ void discoveryEnabled() {
assertThat(context).hasSingleBean(KubernetesInformerReactiveDiscoveryClient.class);

// simple from commons and ours
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).size().isEqualTo(2);
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).hasSize(2);
assertThat(context).hasSingleBean(KubernetesDiscoveryClientHealthIndicatorInitializer.class);
assertThat(context).hasBean("reactiveIndicatorInitializer");

Expand All @@ -131,7 +131,7 @@ void discoveryEnabledWithSelectiveNamespaces() {
assertThat(context).hasSingleBean(KubernetesInformerReactiveDiscoveryClient.class);

// simple from commons and ours
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).size().isEqualTo(2);
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).hasSize(2);
assertThat(context).hasSingleBean(KubernetesDiscoveryClientHealthIndicatorInitializer.class);
assertThat(context).hasBean("reactiveIndicatorInitializer");

Expand Down Expand Up @@ -182,7 +182,7 @@ void kubernetesDiscoveryEnabled() {
assertThat(context).hasSingleBean(KubernetesInformerReactiveDiscoveryClient.class);

// simple from commons and ours
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).size().isEqualTo(2);
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).hasSize(2);
assertThat(context).hasSingleBean(KubernetesDiscoveryClientHealthIndicatorInitializer.class);
assertThat(context).hasBean("reactiveIndicatorInitializer");

Expand All @@ -201,7 +201,7 @@ void kubernetesDiscoveryEnabledWithSelectiveNamespaces() {
assertThat(context).hasSingleBean(KubernetesInformerReactiveDiscoveryClient.class);

// simple from commons and ours
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).size().isEqualTo(2);
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).hasSize(2);
assertThat(context).hasSingleBean(KubernetesDiscoveryClientHealthIndicatorInitializer.class);
assertThat(context).hasBean("reactiveIndicatorInitializer");

Expand Down Expand Up @@ -254,7 +254,7 @@ void kubernetesReactiveDiscoveryEnabled() {
assertThat(context).hasSingleBean(KubernetesInformerReactiveDiscoveryClient.class);

// simple from commons and ours
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).size().isEqualTo(2);
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).hasSize(2);
assertThat(context).hasSingleBean(KubernetesDiscoveryClientHealthIndicatorInitializer.class);
assertThat(context).hasBean("reactiveIndicatorInitializer");

Expand All @@ -273,7 +273,7 @@ void kubernetesReactiveDiscoveryEnabledWithSelectiveNamespaces() {
assertThat(context).hasSingleBean(KubernetesInformerReactiveDiscoveryClient.class);

// simple from commons and ours
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).size().isEqualTo(2);
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).hasSize(2);
assertThat(context).hasSingleBean(KubernetesDiscoveryClientHealthIndicatorInitializer.class);
assertThat(context).hasBean("reactiveIndicatorInitializer");

Expand Down Expand Up @@ -327,7 +327,7 @@ void blockingDisabled() {
assertThat(context).hasSingleBean(KubernetesInformerReactiveDiscoveryClient.class);

// simple from commons and ours
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).size().isEqualTo(2);
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).hasSize(2);
assertThat(context).hasSingleBean(KubernetesDiscoveryClientHealthIndicatorInitializer.class);
assertThat(context).hasBean("reactiveIndicatorInitializer");

Expand All @@ -349,7 +349,7 @@ void blockingDisabledWithSelectiveNamespaces() {
assertThat(context).hasSingleBean(KubernetesInformerReactiveDiscoveryClient.class);

// simple from commons and ours
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).size().isEqualTo(2);
assertThat(context).getBeans(ReactiveDiscoveryClientHealthIndicator.class).hasSize(2);
assertThat(context).hasSingleBean(KubernetesDiscoveryClientHealthIndicatorInitializer.class);
assertThat(context).hasBean("reactiveIndicatorInitializer");

Expand Down