fix 1963: order for discovery clients #1964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wind57
commented
Jul 31, 2025
| .subscribeOn(Schedulers.boundedElastic()); | ||
| } | ||
|
|
||
| @Override |
Contributor
Author
There was a problem hiding this comment.
since we use the same properties for the reactive and blocking reactive clients + our reactive clients are based on the blocking ones, we can re-use the order here
Signed-off-by: wind57 <[email protected]>
wind57
commented
Jul 31, 2025
| } | ||
|
|
||
| private Lister<V1Endpoints> setupEndpointsLister(String namespace, V1Endpoints... endpoints) { | ||
| private Lister<V1Endpoints> setupEndpointsLister(V1Endpoints... endpoints) { |
Contributor
Author
There was a problem hiding this comment.
minor simplification that is un-related to the issue itself
wind57
changed the title
Contributor
Author
|
@ryanjbaxter one more fix ready here. thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.